Once more added a lot of unit tests

Author: sebastianfeldmann

tests/phpbu/Backup/Cli/CmdTest.php

@@ -2,7 +2,7 @@
 namespace phpbu\Backup\Cli;
 
 /**
- * ExecTest
+ * CmdTest
  *
  * @package    phpbu
  * @subpackage tests
@@ -12,34 +12,37 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 1.0.5
  */
-class ExecTest extends \PHPUnit_Framework_TestCase
+class CmdTest extends \PHPUnit_Framework_TestCase
 {
     /**
-     * Tests Exec::getExec
-     *
-     * @expectedException \phpbu\App\Exception
+     * Tests Cmd::getName
      */
-    public function testGetExecFail()
+    public function testGetName()
     {
-        $exec = new Exec();
-        $exec->getExec();
+        $cmd = new Cmd('foo');
 
-        $this->assertFalse(true, 'exception should be thrown');
+        $this->assertEquals('foo', $cmd->getName(), 'name getter should work properly');
     }
 
     /**
      * Tests Cmd::addArgument
      */
-    public function testGetExecOk()
+    public function testAddArgumentPlain()
     {
         $cmd = new Cmd('foo');
-        $cmd->addArgument(array('bar', 'baz'));
+        $cmd->addArgument('bar');
 
-        $exec = new Exec();
-        $exec->addCommand($cmd);
+        $this->assertEquals('foo \'bar\'', (string) $cmd, 'argument should be added');
+    }
 
-        $res = $exec->getExec();
+    /**
+     * Tests Cmd::addArgument
+     */
+    public function testAddArgumentArray()
+    {
+        $cmd = new Cmd('foo');
+        $cmd->addArgument(array('bar', 'baz'));
 
-        $this->assertEquals('foo \'bar\' \'baz\'', $res, 'command should be as planned');
+        $this->assertEquals('foo \'bar\' \'baz\'', (string) $cmd, 'arguments should be added');
     }
 }

tests/phpbu/Backup/Cli/ExecTest.php

@@ -2,7 +2,7 @@
 namespace phpbu\Backup\Cli;
 
 /**
- * CmdTest
+ * ExecTest
  *
  * @package    phpbu
  * @subpackage tests
@@ -12,37 +12,48 @@
  * @link       http://www.phpbu.de/
  * @since      Class available since Release 1.0.5
  */
-class CmdTest extends \PHPUnit_Framework_TestCase
+class ExecTest extends \PHPUnit_Framework_TestCase
 {
     /**
-     * Tests Cmd::getName
+     * Tests Exec::getExec
+     *
+     * @expectedException \phpbu\App\Exception
      */
-    public function testGetName()
+    public function testGetExecFail()
     {
-        $cmd = new Cmd('foo');
+        $exec = new Exec();
+        $exec->getExec();
 
-        $this->assertEquals('foo', $cmd->getName(), 'name getter should work properly');
+        $this->assertFalse(true, 'exception should be thrown');
     }
 
     /**
      * Tests Cmd::addArgument
      */
-    public function testAddArgumentPlain()
+    public function testGetExecOk()
     {
         $cmd = new Cmd('foo');
-        $cmd->addArgument('bar');
+        $cmd->addArgument(array('bar', 'baz'));
+
+        $exec = new Exec();
+        $exec->addCommand($cmd);
+
+        $res = $exec->getExec();
 
-        $this->assertEquals('foo \'bar\'', (string) $cmd, 'argument should be added');
+        $this->assertEquals('foo \'bar\' \'baz\'', $res, 'command should be as planned');
     }
 
     /**
-     * Tests Cmd::addArgument
+     * Tests Exec::execute
      */
-    public function testAddArgumentArray()
+    public function testExecute()
     {
-        $cmd = new Cmd('foo');
-        $cmd->addArgument(array('bar', 'baz'));
+        $cmd  = new Cmd('echo 1');
+        $exec = new Exec();
+        $exec->addCommand($cmd);
+
+        $res  = $exec->execute();
 
-        $this->assertEquals('foo \'bar\' \'baz\'', (string) $cmd, 'arguments should be added');
+        $this->assertEquals(0, $res->getCode(), 'scho should work everywhere');
     }
 }

tests/phpbu/Backup/Cli/ResultTest.php

@@ -0,0 +1,79 @@
+<?php
+namespace phpbu\Backup\Cli;
+
+/**
+ * CmdTest
+ *
+ * @package    phpbu
+ * @subpackage tests
+ * @author     Sebastian Feldmann <sebastian@phpbu.de>
+ * @copyright  Sebastian Feldmann <sebastian@phpbu.de>
+ * @license    http://www.opensource.org/licenses/BSD-3-Clause  The BSD 3-Clause License
+ * @link       http://www.phpbu.de/
+ * @since      Class available since Release 1.0.5
+ */
+class ResultTest extends \PHPUnit_Framework_TestCase
+{
+    /**
+     * Tests Cmd::getCode
+     */
+    public function testGetCode()
+    {
+        $result = new Result('echo 1', 0, array());
+        $this->assertEquals(0, $result->getCode(), 'code getter should work properly');
+    }
+
+    /**
+     * Tests Cmd::wasSuccessful
+     */
+    public function testWasSuccessfulTrue()
+    {
+        $result = new Result('echo 1', 0, array());
+        $this->assertEquals(true, $result->wasSuccessful(), 'should be successful on code 0');
+    }
+
+    /**
+     * Tests Cmd::wasSuccessful
+     */
+    public function testWasSuccessfulFalse()
+    {
+        $result = new Result('echo 1', 1, array());
+        $this->assertEquals(false, $result->wasSuccessful(), 'should not be successful on code 1');
+    }
+
+    /**
+     * Tests Cmd::getCmd
+     */
+    public function testGetCmd()
+    {
+        $result = new Result('echo 1', 0, array());
+        $this->assertEquals('echo 1', $result->getCmd(), 'cmd getter should work properly');
+    }
+
+    /**
+     * Tests Cmd::getOutput
+     */
+    public function testGetOutput()
+    {
+        $result = new Result('echo 1', 0, array('foo', 'bar'));
+        $this->assertEquals(2, count($result->getOutput()), 'output getter should work properly');
+    }
+
+    /**
+     * Tests Cmd::getOutput
+     */
+    public function testGetOutputAsString()
+    {
+        $result = new Result('echo 1', 0, array('foo', 'bar'));
+        $this->assertEquals('foo' . PHP_EOL . 'bar', $result->getOutput(true), 'outputAsString getter should work properly');
+    }
+
+    /**
+     * Tests Cmd::__toString
+     */
+    public function testToString()
+    {
+        $result = new Result('echo 1', 0, array('foo'));
+        $this->assertEquals('foo', (string) $result, 'toString should work properly');
+    }
+}