Skip to content

Commit 86a6d88

Browse files
Use empty string as getValue default - issue #174
1 parent 79025a2 commit 86a6d88

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/Configuration/Loader/Json.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ public function setBackups(Configuration $configuration)
175175
*/
176176
private function getBackupConfig(array $json)
177177
{
178-
$name = $this->getAdapterizedValue(Arr::getValue($json, 'name'));
178+
$name = $this->getAdapterizedValue(Arr::getValue($json, 'name', ''));
179179
$stopOnFailure = Arr::getValue($json, 'stopOnFailure', false);
180180
$backup = new Configuration\Backup($name, $stopOnFailure);
181181

@@ -222,8 +222,8 @@ protected function getTarget(array $json)
222222
throw new Exception('backup requires a target config');
223223
}
224224
$compress = Arr::getValue($json['target'], 'compress');
225-
$filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename'));
226-
$dirname = $this->getAdapterizedValue(Arr::getValue($json['target'], 'dirname'));
225+
$filename = $this->getAdapterizedValue(Arr::getValue($json['target'], 'filename',''));
226+
$dirname = $this->getAdapterizedValue(Arr::getValue($json['target'], 'dirname', ''));
227227

228228
if ($dirname) {
229229
$dirname = $this->toAbsolutePath($dirname);
@@ -316,10 +316,11 @@ protected function setCleanup(Configuration\Backup $backup, array $json)
316316
}
317317

318318
/**
319-
* Extracts all option tags.
319+
* Extracts all option tags
320320
*
321321
* @param array $json
322322
* @return array
323+
* @throws \phpbu\App\Exception
323324
*/
324325
protected function getOptions(array $json)
325326
{

0 commit comments

Comments
 (0)