Merge pull request #218 from rhorber

Allow mysqldump to skip triggers

Author: sebastianfeldmann

src/Backup/Source/Mysqldump.php

@@ -192,6 +192,14 @@ class Mysqldump extends SimulatorExecutable implements Simulator, Restorable
      */
     private $routines;
 
+    /**
+     * Skip triggers
+     * --skip-triggers
+     *
+     * @var bool
+     */
+    private $skipTriggers;
+
     /**
      * Setup.
      *
@@ -221,6 +229,7 @@ public function setup(array $conf = [])
         $this->noData            = Util\Str::toBoolean(Util\Arr::getValue($conf, 'noData', ''), false);
         $this->filePerTable      = Util\Str::toBoolean(Util\Arr::getValue($conf, 'filePerTable', ''), false);
         $this->routines          = Util\Str::toBoolean(Util\Arr::getValue($conf, 'routines', ''), false);
+        $this->skipTriggers      = Util\Str::toBoolean(Util\Arr::getValue($conf, 'skipTriggers', ''), false);
 
         // this doesn't fail, but it doesn't work, so throw an exception so the user understands
         if ($this->filePerTable && count($this->structureOnly)) {
@@ -331,6 +340,7 @@ protected function createExecutable(Target $target) : Executable
                    ->produceFilePerTable($this->filePerTable)
                    ->dumpNoData($this->noData)
                    ->dumpRoutines($this->routines)
+                   ->skipTriggers($this->skipTriggers)
                    ->dumpStructureOnly($this->structureOnly)
                    ->dumpTo($this->getDumpTarget($target));
         // if compression is active and commands can be piped

src/Cli/Executable/Mysqldump.php

@@ -172,6 +172,14 @@ class Mysqldump extends Abstraction implements Executable
      */
     private $routines = false;
 
+    /**
+     * Skip triggers
+     * --skip-triggers
+     *
+     * @var boolean
+     */
+    private $skipTriggers = false;
+
     /**
      * Path to dump file
      *
@@ -415,6 +423,18 @@ public function dumpRoutines(bool $bool) : Mysqldump
         return $this;
     }
 
+    /**
+     * Skip triggers.
+     *
+     * @param  bool $bool
+     * @return \phpbu\App\Cli\Executable\Mysqldump
+     */
+    public function skipTriggers(bool $bool) : Mysqldump
+    {
+        $this->skipTriggers = $bool;
+        return $this;
+    }
+
     /**
      * Pipe compressor.
      *
@@ -464,6 +484,7 @@ protected function createCommandLine() : CommandLine
         $cmd->addOptionIfNotEmpty('--hex-blob', $this->hexBlob, false);
         $cmd->addOptionIfNotEmpty('--set-gtid-purged', $this->gtidPurged);
         $cmd->addOptionIfNotEmpty('--routines', $this->routines, false);
+        $cmd->addOptionIfNotEmpty('--skip-triggers', $this->skipTriggers, false);
 
         $this->configureSourceData($cmd);
         $this->configureIgnoredTables($cmd);

tests/phpbu/Backup/Source/MysqldumpTest.php

@@ -176,6 +176,20 @@ public function testExtendedInsert()
         $this->assertEquals(PHPBU_TEST_BIN . '/mysqldump -e --all-databases', $executable->getCommand());
     }
 
+    /**
+     * Tests Mysqldump::getExecutable
+     */
+    public function testSkipTriggers()
+    {
+        $target    = $this->createTargetMock();
+        $mysqldump = new Mysqldump();
+        $mysqldump->setup(['pathToMysqldump' => PHPBU_TEST_BIN, 'skipTriggers' => 'true']);
+
+        $executable = $mysqldump->getExecutable($target);
+
+        $this->assertEquals(PHPBU_TEST_BIN . '/mysqldump --skip-triggers --all-databases', $executable->getCommand());
+    }
+
     /**
      * Tests Mysqldump::backup
      */

tests/phpbu/Cli/Executable/MysqldumpTest.php

@@ -285,4 +285,18 @@ public function testStructureOnly()
             $mysqldump->getCommand()
         );
     }
+
+    /**
+     * Tests Mysqldump::getCommand
+     */
+    public function testSkipTriggers()
+    {
+        $mysqldump = new Mysqldump(PHPBU_TEST_BIN);
+        $mysqldump->skipTriggers(true);
+
+        $this->assertEquals(
+            PHPBU_TEST_BIN . '/mysqldump --skip-triggers --all-databases',
+            $mysqldump->getCommand()
+        );
+    }
 }