Enable phpstan level 2

Author: marcelthole

.travis.yml

@@ -9,9 +9,11 @@ before_script:
   - composer self-update
   - composer install --no-interaction --prefer-source
   - wget -O phpunit.phar https://phar.phpunit.de/phpunit-6.5.6.phar
+  - if [ $TRAVIS_PHP_VERSION = "7.1" ]; then wget -O phpstan.phar https://github.com/phpstan/phpstan/releases/download/0.10.5/phpstan.phar ; fi
 
 script:
   - php phpunit.phar --configuration ./build/travis-ci.phpunit.xml
+  - if [ $TRAVIS_PHP_VERSION = "7.1" ]; then php phpstan.phar analyse --no-progress -c phpstan.neon; fi
 
 after_success:
   - wget https://scrutinizer-ci.com/ocular.phar

phpstan.neon

@@ -0,0 +1,10 @@
+parameters:
+  level: 2
+  paths:
+  - %currentWorkingDirectory%/src/
+  ignoreErrors:
+      - '#Call to an undefined method SebastianFeldmann\\Ftp\\Client::delete\(\)#'
+      - '#Call to an undefined method ObjectStorage_Abstract::setLocalFile\(\)#'
+      - '#Instantiated class phpbu\\App\\Runner\\Restore not found#'
+      - '#Cannot cast DateTimeImmutable to int#'
+      - '#Cannot call method getTimestamp\(\) on string#'

src/Backup/Cleaner/Quantity.php

@@ -76,7 +76,7 @@ protected function getFilesToDelete(Target $target, Collector $collector)
     /**
      * Returns true when the capacity is exceeded.
      *
-     * @param  array
+     * @param  array $files
      * @return bool
      */
     private function isCapacityExceeded(array $files)

src/Backup/Crypter.php

@@ -27,7 +27,7 @@ public function setup(array $options = []);
      * Checks the created backup.
      *
      * @param  \phpbu\App\Backup\Target $target
-     * @param  \phpbu\App\Result
+     * @param  \phpbu\App\Result $result
      * @throws \phpbu\App\Exception
      */
     public function crypt(Target $target, Result $result);

src/Backup/Source/Arangodump.php

@@ -173,7 +173,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/Redis.php

@@ -123,7 +123,7 @@ public function backup(Target $target, Result $result) : Status
     /**
      * Setup the Executable to run the 'tar' command.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Cli\Executable
      */
     protected function createExecutable(Target $target) : Executable
@@ -208,7 +208,7 @@ private function copyDumpToTarget(Target $target) : string
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/Rsync.php

@@ -59,7 +59,7 @@ public function backup(Target $target, Result $result) : Status
     /**
      * Setup the Executable to run the 'rsync' command.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Cli\Executable
      */
     protected function createExecutable(Target $target) : Executable
@@ -86,7 +86,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/Tar.php

@@ -170,7 +170,7 @@ public function backup(Target $target, Result $result) : Status
     /**
      * Setup the Executable to run the 'tar' command.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Cli\Executable
      */
     protected function createExecutable(Target $target) : Executable
@@ -216,7 +216,7 @@ private function validatePath()
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Source/XtraBackup.php

@@ -150,7 +150,7 @@ protected function createExecutable(Target $target) : Executable
     /**
      * Create backup status.
      *
-     * @param  \phpbu\App\Backup\Target
+     * @param  \phpbu\App\Backup\Target $target
      * @return \phpbu\App\Backup\Source\Status
      */
     protected function createStatus(Target $target) : Status

src/Backup/Sync/AmazonS3v3.php

@@ -187,7 +187,7 @@ private function uploadStream(Target $target, S3Client $s3)
      *
      * @param \phpbu\App\Backup\Target $target
      * @param \Aws\S3\S3Client         $s3
-     * @param \Aws\Exception\MultipartUploadException
+     * @throws \Aws\Exception\MultipartUploadException
      */
     private function uploadMultiPart(Target $target, S3Client $s3)
     {