Refactored duplicated code to parent class

Author: sebastianfeldmann

src/Backup/Cli/Binary.php

@@ -3,6 +3,7 @@
 
 use phpbu\App\Backup\Compressor;
 use phpbu\App\Backup\Target;
+use phpbu\App\Util\Cli;
 
 /**
  * Execute Binary
@@ -45,6 +46,16 @@ abstract class Binary
         'tar'       => array(),
     );
 
+    /**
+     * @param  string $cmd
+     * @param  string $path
+     * @return string
+     */
+    protected function detectCommand($cmd, $path = null)
+    {
+        return Cli::detectCmdLocation($cmd, $path, self::getCommandLocations($cmd));
+    }
+
     /**
      * Executes the cli commands and handles compression
      *

src/Backup/Source/Mongodump.php

@@ -148,11 +148,7 @@ public function setup(array $conf = array())
     protected function setupMongodump(array $conf)
     {
         if (empty($this->binary)) {
-            $this->binary = Util\Cli::detectCmdLocation(
-                'mongodump',
-                Util\Arr::getValue($conf, 'pathToMongodump'),
-                Binary::getCommandLocations('mongodump')
-            );
+            $this->binary = $this->detectCommand('mongodump', Util\Arr::getValue($conf, 'pathToMongodump'));
         }
     }
 

src/Backup/Source/Mysqldump.php

@@ -145,11 +145,7 @@ public function setup(array $conf = array())
     protected function setupMysqldump(array $conf)
     {
         if (empty($this->binary)) {
-            $this->binary = Util\Cli::detectCmdLocation(
-                'mysqldump',
-                Util\Arr::getValue($conf, 'pathToMysqldump'),
-                Binary::getCommandLocations('mysqldump')
-            );
+            $this->binary = $this->detectCommand('mysqldump', Util\Arr::getValue($conf, 'pathToMysqldump'));
         }
     }
 

src/Backup/Source/Tar.php

@@ -71,11 +71,7 @@ public function setup(array $conf = array())
     protected function setupTar(array $conf)
     {
         if (empty($this->binary)) {
-            $this->binary = Util\Cli::detectCmdLocation(
-                'tar',
-                Util\Arr::getValue($conf, 'pathToTar'),
-                Binary::getCommandLocations('tar')
-            );
+            $this->binary = $this->detectCommand('tar', Util\Arr::getValue($conf, 'pathToTar'));
         }
     }