Merge branch 'development'

Author: Martin Mory

.clang-tidy

@@ -15,6 +15,7 @@ Checks: '-*,
            -readability-function-cognitive-complexity,
            -readability-convert-member-functions-to-static,
            -readability-isolate-declaration,
+           -readability-identifier-length,
          cppcoreguidelines-*,
            -cppcoreguidelines-avoid-non-const-global-variables,
            -cppcoreguidelines-pro-bounds-array-to-pointer-decay,
@@ -28,7 +29,6 @@ Checks: '-*,
            -bugprone-easily-swappable-parameters,
          modernize-*,
            -modernize-use-trailing-return-type,
-           -modernize-pass-by-value,
          performance-*,
          clang-analyzer-*,
         '

.github/CODEOWNERS

@@ -0,0 +1,26 @@
+# Patterns listed later take precedence over earlier patterns.
+# All owners are automatically set as reviewers for PRs affecting their files.
+# At least one owner must approve a PR affecting their files.
+
+* @MMory @fabianbs96
+
+/include/phasar/PhasarLLVM/DataflowSolver/IfdsIde/Solver/IDESolver.h @pdschubert
+
+/include/phasar/PhasarLLVM/DataflowSolver/IfdsIde/FlowEdgeFunctionCache.h @vulder
+
+/include/phasar/PhasarLLVM/DataflowSolver/Mono @pdschubert
+
+/img @pdschubert
+
+/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEInstInteractionAnalysis.h @pdschubert @vulder
+/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/ @fabianbs96
+/include/phasar/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEExtendedTaintAnalysis.h @fabianbs96
+/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/IDEExtendedTaintAnalysis.cpp @fabianbs96
+/lib/PhasarLLVM/DataFlowSolver/IfdsIde/Problems/ExtendedTaintAnalysis/ @fabianbs96
+
+/include/phasar/PhasarLLVM/AnalysisStrategy/ @pdschubert
+
+Dockerfile @janniclas
+/.docker/ @janniclas
+
+/include/phasar/Utils/Logger.h @MMory

CMakeLists.txt

@@ -125,8 +125,8 @@ endif()
 find_package(Threads)
 
 # Boost
-find_package(Boost 1.65.1 COMPONENTS graph program_options ${BOOST_THREAD} REQUIRED)
-#find_package(Boost 1.72.0 COMPONENTS graph program_options ${BOOST_THREAD} REQUIRED)
+find_package(Boost 1.65.1 COMPONENTS graph ${BOOST_THREAD} REQUIRED)
+#find_package(Boost 1.72.0 COMPONENTS graph  ${BOOST_THREAD} REQUIRED)
 include_directories(${Boost_INCLUDE_DIRS})
 
 # Disable clang-tidy for the external projects

CREDITS.txt

@@ -2,22 +2,36 @@ This file is a partial list of people who have contributed to Phasar
 
 The fields are: name (N), email (E), web-address (W), description (D)
 
+
+Active Contributors:
+
 N: Philipp Schubert
 E: philipp.schubert@upb.de
 W: http://it-schubert.com
-D: Initial implementation and chief developer new features
+D: Initial implementation, high-level architecture, IDESolver, InstInteractionAnalysis
 
 N: Martin Mory
 E: martin.mory@upb.de
-D: CMake
+D: CMake, Logger, Organization
 
-N: Nicolas Bellec
-E: nicolas.bellec@ens-rennes.fr
-D: Call-graph algorithms
+N: Fabian Schiebel
+E: fabian.schiebel@iem.fraunhofer.de, fabianbs@mail.upb.de
+D: ExtendedTaintAnalysis, general development, Organization
+
+N: Jan-Niclas Strüwer
+E: struewer@mail.upb.de
+D: ESG visualization adaptor, Docker, Mac Support
 
 N: Florian Sattler
 E: sattlerf@fim.uni-passau.de
-D: CMake and CMake build as llvm drop-in
+D: CMake and CMake build as llvm drop-in, CI/CD Pipeline, Performance, InstInteractionAnalysis
+
+
+Former Contributors:
+
+N: Nicolas Bellec
+E: nicolas.bellec@ens-rennes.fr
+D: Call-graph algorithms
 
 N: Christian Stritzke
 E: christian.stritzke@iem.fraunhofer.de
@@ -26,7 +40,3 @@ D: HexaStore implementation
 N: Richard Leer
 E: rleer@mail.upb.de
 D: Serialization, various fixes and data-flow analyses
-
-N: Jan-Niclas Strüwer
-E: struewer@mail.upb.de
-D: ESG visualization adaptor

Config.cmake.in

@@ -3,24 +3,47 @@ set(PHASAR_VERSION 1.0.0)
 @PACKAGE_INIT@
 set_and_check(PHASAR_INCLUDE_DIR "@PACKAGE_INCLUDE_INSTALL_DIR@")
 
-foreach(component ${phasar_FIND_COMPONENTS})
-  include("${CMAKE_CURRENT_LIST_DIR}/phasar_${component}-config.cmake")
+include (CMakeFindDependencyMacro)
+find_dependency(nlohmann_json)
+find_dependency(nlohmann_json_schema_validator)
+find_package(Boost 1.65.1 COMPONENTS program_options graph REQUIRED)
+
+# TODO: The order seems to be important. Fix this!
+
+set(PHASAR_COMPONENTS
+  utils
+  config
+  phasarllvm_utils
+  passes
+  db
+  pointer
+  typehierarchy
+  controlflow
+  taintconfig
+  ifdside
+)
+
+foreach(component ${PHASAR_COMPONENTS})
   include("${CMAKE_CURRENT_LIST_DIR}/phasar_${component}-targets.cmake")
+  list(APPEND PHASAR_NEEDED_LIBS phasar::phasar_${component})
 endforeach()
 
+list(REMOVE_DUPLICATES PHASAR_NEEDED_LIBS)
+
+find_package(LLVM 14 REQUIRED CONFIG)
+include_directories(${LLVM_INCLUDE_DIRS})
+link_directories(${LLVM_LIB_PATH} ${LLVM_LIBRARY_DIRS})
+find_library(LLVM_LIBRARY NAMES LLVM HINTS ${LLVM_LIBRARY_DIRS})
+
 function(phasar_config executable)
-  find_package(LLVM 14 REQUIRED CONFIG)
-  include_directories(${LLVM_INCLUDE_DIRS})
-  link_directories(${LLVM_LIB_PATH} ${LLVM_LIBRARY_DIRS})
-  find_library(LLVM_LIBRARY NAMES LLVM HINTS ${LLVM_LIBRARY_DIRS})
   if(NOT ${LLVM_LIBRARY} STREQUAL "LLVM_LIBRARY-NOTFOUND")
     llvm_config(${executable} USE_SHARED ${PHASAR_LLVM_DEPS})
   else()
     llvm_config(${executable} ${PHASAR_LLVM_DEPS})
   endif()
-  list(REMOVE_DUPLICATES PHASAR_NEEDED_LIBS)
+
   target_link_libraries(${executable}
     PUBLIC
     ${PHASAR_NEEDED_LIBS}
-    )
+  )
 endfunction()