diff --git a/libbitcoinkernel-sys/bitcoin/CMakeLists.txt b/libbitcoinkernel-sys/bitcoin/CMakeLists.txt index 1b1df77b..eb27f989 100644 --- a/libbitcoinkernel-sys/bitcoin/CMakeLists.txt +++ b/libbitcoinkernel-sys/bitcoin/CMakeLists.txt @@ -488,9 +488,8 @@ try_append_cxx_flags("-fno-extended-identifiers" TARGET core_interface SKIP_LINK # which can cause issues with coverage builds, particularly when using # Clang in the OSS-Fuzz environment due to its use of other options # and a third party script, or with GCC. -try_append_cxx_flags("-fdebug-prefix-map=A=B" TARGET core_interface SKIP_LINK - IF_CHECK_PASSED "-fdebug-prefix-map=${PROJECT_SOURCE_DIR}/src=." -) +# Set `-fmacro-prefix-map`, so that source file names are expanded without the +# src prefix. try_append_cxx_flags("-fmacro-prefix-map=A=B" TARGET core_interface SKIP_LINK IF_CHECK_PASSED "-fmacro-prefix-map=${PROJECT_SOURCE_DIR}/src=." ) diff --git a/libbitcoinkernel-sys/bitcoin/CONTRIBUTING.md b/libbitcoinkernel-sys/bitcoin/CONTRIBUTING.md index 7f42f0be..83a0919a 100644 --- a/libbitcoinkernel-sys/bitcoin/CONTRIBUTING.md +++ b/libbitcoinkernel-sys/bitcoin/CONTRIBUTING.md @@ -78,6 +78,13 @@ The codebase is maintained using the "contributor workflow" where everyone without exception contributes patch proposals using "pull requests" (PRs). This facilitates social contribution, easy testing and peer review. +Pull request authors must fully and confidently understand their own changes +and must have tested them. Contributors should mention which tests cover their +changes, or include the manual steps they used to confirm the change. +Contributors are expected to be prepared to clearly motivate and explain their +changes. If there is doubt, the pull request may be closed. +Please refer to the [peer review](#peer-review) section below for more details. + To contribute a patch, the workflow is as follows: 1. Fork repository ([only for the first time](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/fork-a-repo)) @@ -338,6 +345,11 @@ reviewers that the changes warrant the review effort, and if reviewers are "Concept NACK'ing" the PR, the author may need to present arguments and/or do research backing their suggested changes. +Moreover, if there is reasonable doubt that the pull request author does not +fully understand the changes they are submitting themselves, or if it becomes +clear that they have not tested the changes on a basic level themselves, the +pull request may be closed immediately. + #### Conceptual Review A review can be a conceptual review, where the reviewer leaves a comment diff --git a/libbitcoinkernel-sys/bitcoin/contrib/guix/libexec/build.sh b/libbitcoinkernel-sys/bitcoin/contrib/guix/libexec/build.sh index f4db25f4..1eaa86ae 100755 --- a/libbitcoinkernel-sys/bitcoin/contrib/guix/libexec/build.sh +++ b/libbitcoinkernel-sys/bitcoin/contrib/guix/libexec/build.sh @@ -211,6 +211,7 @@ CONFIGFLAGS="-DREDUCE_EXPORTS=ON -DBUILD_BENCH=OFF -DBUILD_GUI_TESTS=OFF -DBUILD # CFLAGS HOST_CFLAGS="-O2 -g" HOST_CFLAGS+=$(find /gnu/store -maxdepth 1 -mindepth 1 -type d -exec echo -n " -ffile-prefix-map={}=/usr" \;) +HOST_CFLAGS+=" -fdebug-prefix-map=${DISTSRC}/src=." case "$HOST" in *mingw*) HOST_CFLAGS+=" -fno-ident" ;; *darwin*) unset HOST_CFLAGS ;; diff --git a/libbitcoinkernel-sys/bitcoin/src/bench/connectblock.cpp b/libbitcoinkernel-sys/bitcoin/src/bench/connectblock.cpp index 434bcdcb..4108476f 100644 --- a/libbitcoinkernel-sys/bitcoin/src/bench/connectblock.cpp +++ b/libbitcoinkernel-sys/bitcoin/src/bench/connectblock.cpp @@ -9,6 +9,7 @@ #include