PHP 7 support

[markjeffries]

Hi,

Do you have any plans to work on the extension for PHP 7?

regards

Mark

[pilif]

yes. I will start porting in the next month or two unless somebody wants to send a PR :-)

[absalomedia]

PHP7 shouldn't be that hard to refactor for. I'm midway through already.

https://travis-ci.org/absalomedia/sassphp/jobs/89573716

[markjeffries]

Great, thanks for the info!

[absalomedia]

Well I have a successful build for PHP7: https://travis-ci.org/absalomedia/sassphp/jobs/90245122 I'll start cherry picking stuff ready for a PR

[markjeffries]

Great news! We'll test it once it's ready.

best regards

Mark

On 10 November 2015 at 05:35, Lawrence Meckan notifications@github.com
wrote:

Well I have a successful build for PHP7:
https://travis-ci.org/absalomedia/sassphp/jobs/90245122 I'll start cherry
picking stuff ready for a PR

—
Reply to this email directly or view it on GitHub
#30 (comment).

[absalomedia]

PR done #31

The fixes I've done also resolve #23 as for some reason I fixed it in my build but somehow the documentation didn't merge correctly.

[studdugie]

Hello. Any idea about when this will be merged? It's the only thing stopping me from putting PHP7 into production. If you need me to help test it or anything please let me know.

Regards,

Dane

[absalomedia]

Only thing I've had repeated issues on is Travis segfaulting when trying to run PHPT data. It builds ok, passes all tests locally it's just Travis don't like my test setup for some reason.

[studdugie]

That's great news! Unfortunately git/github is not my normal stomping ground so I need some guidance. Where can I get your sources so I can build it and test my program against it?

[absalomedia]

Here: https://github.com/absalomedia/sassphp

I'm confident it builds successfully under PHP7.

[asterixcapri]

I cloned https://github.com/absalomedia/sassphp repository and the build was successfully. But when i run this simple script I receive a segmentation fault:

$sass = new \Sass();
echo $sass->compileFile(\file_get_contents("test.scss"))."\n";

This is test.scss

$color:#f60;
.error { color:$color; }

I'm building against php 7.0.1.

Alex

[absalomedia]

@asterixcapri,

This is from the PHPT file that tests file compilation:

$sass = new Sass();
$css = $sass->compileFile('tests/support/test.scss');
echo $css;

You shouldn't need to a file_get_contents call to get the output.

[asterixcapri]

Sorry, you are right, file_get_contents is not necessary. But the segmentation fault is happen anyway.

[studdugie]

Hello,

Any progress on the segmentation fault? I'm trying to go live w/ PHP7 next week Tuesday and I don't have a work around for this so any progress would be greatly, greatly, greatly appreciated!

[absalomedia]

I'm building on Debian & Travis. I'm still working on getting stack traces from them. It might help if I had the stack dump from @asterixcapri as well.