Skip to content

enhancement(actions): route github.actor through env in git-config steps #35

Description

@MAfarrag

Context

Security review (same interpolation anti-pattern class as the release-tag injection); fixed in PR #28.

Problem

git config user.name '${{ github.actor }}' interpolated github.actor into run: bodies in three places. Not
exploitable today (GitHub usernames are restricted to alphanumerics and non-consecutive hyphens), but the same
interpolation anti-pattern the rest of this work removes.

Affected locations

File
actions/mkdocs-deploy/action.yml
actions/release/github/action.yml
.github/workflows/deploy-docs.yml

Fix (PR #28)

env: GIT_ACTOR: ${{ github.actor }} + reference "$GIT_ACTOR".

Severity / Effort

Low · XS

Definition of Done

  • github.actor referenced only via env: in the git-config steps

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions