Merge pull request #319 from neuroglia-io/fix-correlations

Updated the Dashboard's correlation interface by enabling its reactive features, by adding a button to trigger correlations by posting cloud events in-app, and by adding a new view to create explicit correlations

Author: cdavernas

src/apis/management/Synapse.Apis.Management.Core/Services/ISynapseManagementApi.cs

@@ -231,6 +231,27 @@ public interface ISynapseManagementApi
         [OperationContract]
         Task<List<V1Correlation>> GetCorrelationsAsync(string? query = null, CancellationToken cancellationToken = default);
 
+        /// <summary>
+        /// Deletes the specified <see cref="V1CorrelationContext"/>
+        /// </summary>
+        /// <param name="correlationId">The id of the <see cref="V1Correlation"/> the <see cref="V1CorrelationContext"/> to delete belongs to</param>
+        /// <param name="contextId">The id of the <see cref="V1CorrelationContext"/> to delete</param>
+        /// <param name="cancellationToken">A <see cref="CancellationToken"/></param>
+        /// <returns>A new awaitable <see cref="Task"/></returns>
+        [OperationContract]
+        Task DeleteCorrelationContextAsync(string correlationId, string contextId, CancellationToken cancellationToken = default);
+
+        /// <summary>
+        /// Deletes the specified correlated <see cref="V1Event"/>
+        /// </summary>
+        /// <param name="correlationId">The id of the <see cref="V1Correlation"/> the correlated <see cref="V1Event"/> to delete belongs to</param>
+        /// <param name="contextId">The id of the <see cref="V1CorrelationContext"/> the correlated <see cref="V1Event"/> to delete belongs to</param>
+        /// <param name="eventId">The id of the correlated <see cref="V1Event"/> to delete</param>
+        /// <param name="cancellationToken">A <see cref="CancellationToken"/></param>
+        /// <returns>A new awaitable <see cref="Task"/></returns>
+        [OperationContract]
+        Task DeleteCorrelationContextEventAsync(string correlationId, string contextId, string eventId, CancellationToken cancellationToken = default);
+
         /// <summary>
         /// Deletes the <see cref="V1Correlation"/> with the specified id
         /// </summary>

src/apis/management/Synapse.Apis.Management.Grpc.Client/Services/ISynapseGrpcManagementApi.cs

@@ -88,20 +88,14 @@ public virtual async Task<V1Workflow> UploadWorkflowAsync(V1UploadWorkflowComman
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1Workflow>> GetWorkflowsAsync(string query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1Workflow>> GetWorkflowsAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetWorkflowsAsync(query, cancellationToken);
             if (!result.Succeeded)
                 throw new SynapseApiException(result);
             return result.Data!;
         }
 
-        /// <inheritdoc/>
-        public virtual async Task<List<V1Workflow>> GetWorkflowsAsync(CancellationToken cancellationToken = default)
-        {
-            return await this.GetWorkflowsAsync(null!, cancellationToken);
-        }
-
         /// <inheritdoc/>
         public virtual async Task<V1Workflow> GetWorkflowByIdAsync(string id, CancellationToken cancellationToken = default)
         {
@@ -158,20 +152,14 @@ public virtual async Task<V1WorkflowInstance> GetWorkflowInstanceByIdAsync(strin
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1WorkflowInstance>> GetWorkflowInstancesAsync(string query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1WorkflowInstance>> GetWorkflowInstancesAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetWorkflowInstancesAsync(query, cancellationToken);
             if (!result.Succeeded)
                 throw new SynapseApiException(result);
             return result.Data!;
         }
 
-        /// <inheritdoc/>
-        public virtual async Task<List<V1WorkflowInstance>> GetWorkflowInstancesAsync(CancellationToken cancellationToken = default)
-        {
-            return await this.GetWorkflowInstancesAsync(null!, cancellationToken);
-        }
-
         /// <inheritdoc/>
         public virtual async Task SuspendWorkflowInstanceAsync(string id, CancellationToken cancellationToken = default)
         {
@@ -236,7 +224,7 @@ public virtual async Task<V1Correlation> CreateCorrelationAsync(V1CreateCorrelat
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1Correlation>> GetCorrelationsAsync(string query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1Correlation>> GetCorrelationsAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetCorrelationsAsync(query, cancellationToken);
             if (!result.Succeeded)
@@ -245,18 +233,34 @@ public virtual async Task<List<V1Correlation>> GetCorrelationsAsync(string query
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1Correlation>> GetCorrelationsAsync(CancellationToken cancellationToken = default)
+        public virtual async Task<V1Correlation> GetCorrelationByIdAsync(string id, CancellationToken cancellationToken = default)
         {
-            return await this.GetCorrelationsAsync(null!, cancellationToken);
+            if (string.IsNullOrWhiteSpace(id)) throw new ArgumentNullException(nameof(id));
+            var result = await this.Adapter.GetCorrelationByIdAsync(id, cancellationToken);
+            if (!result.Succeeded)
+                throw new SynapseApiException(result);
+            return result.Data!;
         }
 
         /// <inheritdoc/>
-        public virtual async Task<V1Correlation> GetCorrelationByIdAsync(string id, CancellationToken cancellationToken = default)
+        public virtual async Task DeleteCorrelationContextAsync(string correlationId, string contextId, CancellationToken cancellationToken = default)
         {
-            var result = await this.Adapter.GetCorrelationByIdAsync(id, cancellationToken);
+            if (string.IsNullOrWhiteSpace(correlationId)) throw new ArgumentNullException(nameof(correlationId));
+            if (string.IsNullOrWhiteSpace(contextId)) throw new ArgumentNullException(nameof(contextId));
+            var result = await this.Adapter.DeleteCorrelationContextAsync(new() { CorrelationId = correlationId, ContextId = contextId }, cancellationToken);
+            if (!result.Succeeded)
+                throw new SynapseApiException(result);
+        }
+
+        /// <inheritdoc/>
+        public virtual async Task DeleteCorrelationContextEventAsync(string correlationId, string contextId, string eventId, CancellationToken cancellationToken = default)
+        {
+            if (string.IsNullOrWhiteSpace(correlationId)) throw new ArgumentNullException(nameof(correlationId));
+            if (string.IsNullOrWhiteSpace(contextId)) throw new ArgumentNullException(nameof(contextId));
+            if (string.IsNullOrWhiteSpace(eventId)) throw new ArgumentNullException(nameof(eventId));
+            var result = await this.Adapter.DeleteCorrelationContextEventAsync(new() { CorrelationId = correlationId, ContextId = contextId, EventId = eventId }, cancellationToken);
             if (!result.Succeeded)
                 throw new SynapseApiException(result);
-            return result.Data!;
         }
 
         /// <inheritdoc/>
@@ -288,14 +292,9 @@ public virtual async Task<V1AuthenticationDefinitionCollection> GetAuthenticatio
             return result.Data!;
         }
 
-        /// <inheritdoc/>
-        public virtual async Task<List<V1AuthenticationDefinitionCollection>> GetAuthenticationDefinitionCollectionsAsync(CancellationToken cancellationToken = default)
-        {
-            return await this.GetAuthenticationDefinitionCollectionsAsync(null!, cancellationToken);
-        }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1AuthenticationDefinitionCollection>> GetAuthenticationDefinitionCollectionsAsync(string? query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1AuthenticationDefinitionCollection>> GetAuthenticationDefinitionCollectionsAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetAuthenticationDefinitionCollectionsAsync(query, cancellationToken);
             if (!result.Succeeded)
@@ -334,13 +333,7 @@ public virtual async Task<V1EventDefinitionCollection> GetEventDefinitionCollect
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1EventDefinitionCollection>> GetEventDefinitionCollectionsAsync(CancellationToken cancellationToken = default)
-        {
-            return await this.GetEventDefinitionCollectionsAsync(null!, cancellationToken);
-        }
-
-        /// <inheritdoc/>
-        public virtual async Task<List<V1EventDefinitionCollection>> GetEventDefinitionCollectionsAsync(string? query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1EventDefinitionCollection>> GetEventDefinitionCollectionsAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetEventDefinitionCollectionsAsync(query, cancellationToken);
             if (!result.Succeeded)
@@ -379,13 +372,7 @@ public virtual async Task<V1FunctionDefinitionCollection> GetFunctionDefinitionC
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1FunctionDefinitionCollection>> GetFunctionDefinitionCollectionsAsync(CancellationToken cancellationToken = default)
-        {
-            return await this.GetFunctionDefinitionCollectionsAsync(null!, cancellationToken);
-        }
-
-        /// <inheritdoc/>
-        public virtual async Task<List<V1FunctionDefinitionCollection>> GetFunctionDefinitionCollectionsAsync(string query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1FunctionDefinitionCollection>> GetFunctionDefinitionCollectionsAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetFunctionDefinitionCollectionsAsync(query, cancellationToken);
             if (!result.Succeeded)
@@ -437,10 +424,7 @@ public virtual async Task<V1Schedule> GetScheduleByIdAsync(string id, Cancellati
         }
 
         /// <inheritdoc/>
-        public virtual async Task<List<V1Schedule>> GetSchedulesAsync(CancellationToken cancellationToken = default) => await this.GetSchedulesAsync(null!, cancellationToken);
-
-        /// <inheritdoc/>
-        public virtual async Task<List<V1Schedule>> GetSchedulesAsync(string query, CancellationToken cancellationToken = default)
+        public virtual async Task<List<V1Schedule>> GetSchedulesAsync(string? query = null, CancellationToken cancellationToken = default)
         {
             var result = await this.Adapter.GetSchedulesAsync(query, cancellationToken);
             if (!result.Succeeded) throw new SynapseApiException(result);