fix(Core): Fixed the WorkflowCompletedEventV1 by adding a new Output property

fix(Runtimes): Fixed all runtimes to set both the runner's `NAMESPACE` and `NAME` environment variables
fix(ContainerPlatforms): Fixed all container platforms to name spawned containers after both the runner and their image
fix(Runner): Fixed the ContainerTaskExecutor by removing output truncation when using Kubernetes
fix(KubernetesContainerPlatform): Fixed the KubernetesContainer by fixing the WaitForExit method

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>

Author: cdavernas

src/api/Synapse.Api.Application/Commands/Resources/CreateResourceCommand.cs

@@ -79,7 +79,7 @@ public class CreateResourceCommandHandler(IResourceRepository repository)
     /// <inheritdoc/>
     public virtual async Task<IOperationResult<IResource>> HandleAsync(CreateResourceCommand command, CancellationToken cancellationToken)
     {
-        if (command.Resource.GetName().Trim().EndsWith('-')) command.Resource.Metadata.Name = $"{command.Resource.GetName().Trim()}{Guid.NewGuid().ToString("N")[..15]}";
+        if (command.Resource.GetName().Trim().EndsWith('-')) command.Resource.Metadata.Name = $"{command.Resource.GetName().Trim()}{Guid.NewGuid().ToString("N")[..12]}";
         var resource = await repository.AddAsync(command.Resource, command.Group, command.Version, command.Plural, command.DryRun, cancellationToken);
         return new OperationResult<IResource>((int)HttpStatusCode.Created, resource);
     }

src/api/Synapse.Api.Application/Commands/Resources/Generic/CreateResourceCommand.cs

@@ -46,7 +46,7 @@ public class CreateResourceCommandHandler<TResource>(IResourceRepository reposit
     /// <inheritdoc/>
     public virtual async Task<IOperationResult<TResource>> HandleAsync(CreateResourceCommand<TResource> command, CancellationToken cancellationToken)
     {
-        if (command.Resource.GetName().Trim().EndsWith('-')) command.Resource.Metadata.Name = $"{command.Resource.GetName().Trim()}{Guid.NewGuid().ToString("N")[..15]}";
+        if (command.Resource.GetName().Trim().EndsWith('-')) command.Resource.Metadata.Name = $"{command.Resource.GetName().Trim()}{Guid.NewGuid().ToString("N")[..12]}";
         var resource = await repository.AddAsync(command.Resource, false, cancellationToken).ConfigureAwait(false);
         return new OperationResult<TResource>((int)HttpStatusCode.Created, resource);
     }

src/core/Synapse.Core.Infrastructure.Containers.Docker/DockerContainerPlatform.cs

@@ -93,6 +93,7 @@ public virtual async Task<IContainer> CreateAsync(ContainerProcessDefinition def
         }
         var parameters = new CreateContainerParameters()
         {
+            Name = $"{System.Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runner.Name)}-{definition.Image}-{Guid.NewGuid().ToString("N")[..6].ToLowerInvariant()}",
             Image = definition.Image,
             Cmd = string.IsNullOrWhiteSpace(definition.Command) ? null : ["/bin/sh", "-c", definition.Command],
             Env = definition.Environment?.Select(e => $"{e.Key}={e.Value}").ToList(),

src/core/Synapse.Core.Infrastructure.Containers.Kubernetes/KubernetesContainer.cs

@@ -107,10 +107,10 @@ protected virtual async Task WaitForReadyAsync(CancellationToken cancellationTok
     /// <inheritdoc/>
     public virtual async Task WaitForExitAsync(CancellationToken cancellationToken = default)
     {
-        var response = this.Kubernetes.CoreV1.ListNamespacedPodWithHttpMessagesAsync(this.Pod.Namespace(), fieldSelector: $"metadata.name={Pod.Name()}", cancellationToken: cancellationToken);
+        var response = this.Kubernetes.CoreV1.ListNamespacedPodWithHttpMessagesAsync(this.Pod.Namespace(), fieldSelector: $"metadata.name={Pod.Name()}", watch: true, cancellationToken: cancellationToken);
         await foreach (var (_, item) in response.WatchAsync<V1Pod, V1PodList>(cancellationToken: cancellationToken).ConfigureAwait(false))
         {
-            if (item.Status.Phase != "Succeeded" || item.Status.Phase != "Failed") continue;
+            if (item.Status.Phase != "Succeeded" && item.Status.Phase != "Failed") continue;
             var containerStatus = item.Status.ContainerStatuses.FirstOrDefault();
             this.ExitCode = containerStatus?.State.Terminated?.ExitCode ?? -1;
             break;

src/core/Synapse.Core.Infrastructure.Containers.Kubernetes/KubernetesContainerPlatform.cs

@@ -77,17 +77,22 @@ public virtual Task<IContainer> CreateAsync(ContainerProcessDefinition definitio
         if (this.Kubernetes == null) throw new NullReferenceException("The KubernetesContainerPlatform has not been properly initialized");
         var pod = new V1Pod()
         {
+            Metadata = new()
+            {
+                NamespaceProperty = $"{System.Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runner.Namespace)}",
+                Name = $"{System.Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runner.Name)}-{definition.Image}-{Guid.NewGuid().ToString("N")[..6].ToLowerInvariant()}"
+            },
             Spec = new()
             {
+                RestartPolicy = "Never",
                 Containers = 
                 [
-                    new()
+                    new(definition.Image)
                     {
                         Image = definition.Image,
                         ImagePullPolicy = this.Options.ImagePullPolicy,
                         Command = string.IsNullOrWhiteSpace(definition.Command) ? null : ["/bin/sh", "-c", definition.Command],
-                        Env = definition.Environment?.Select(e => new V1EnvVar(e.Key, e.Value)).ToList(),
-                        RestartPolicy = "Never"
+                        Env = definition.Environment?.Select(e => new V1EnvVar(e.Key, e.Value)).ToList()
                     }
                 ]
             }

src/core/Synapse.Core/Events/Workflows/WorkflowCompletedEventV1.cs

@@ -32,4 +32,10 @@ public record WorkflowCompletedEventV1
     [DataMember(Name = "completedAt", Order = 2), JsonPropertyName("completedAt"), JsonPropertyOrder(2), YamlMember(Alias = "completedAt", Order = 2)]
     public DateTimeOffset CompletedAt { get; set; } = DateTimeOffset.Now;
 
+    /// <summary>
+    /// Gets/sets the workflow instance's output
+    /// </summary>
+    [DataMember(Name = "output", Order = 3), JsonPropertyName("output"), JsonPropertyOrder(3), YamlMember(Alias = "output", Order = 3)]
+    public object? Output { get; set; }
+
 }

src/core/Synapse.Core/Resources/Document.cs

@@ -23,7 +23,7 @@ public record Document
 
     /// <inheritdoc/>
     [DataMember(Name = "id", Order = 1), JsonPropertyName("id"), JsonPropertyOrder(1), YamlMember(Alias = "id", Order = 1)]
-    public string Id { get; set; } = Guid.NewGuid().ToString("N")[..15];
+    public string Id { get; set; } = Guid.NewGuid().ToString("N")[..12];
 
     /// <summary>
     /// Gets/sets the document's name

src/core/Synapse.Core/Resources/NativeRuntimeConfiguration.cs

@@ -28,6 +28,10 @@ public record NativeRuntimeConfiguration
     /// Gets the default path to the runner executable file
     /// </summary>
     public const string DefaultExecutable = "Synapse.Runner";
+    /// <summary>
+    /// Gets the default path to the directory that contains the secrets made available to runners
+    /// </summary>
+    public static readonly string DefaultSecretsDirectory = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), ".synapse", "secrets");
 
     /// <summary>
     /// Initializes a new <see cref="NativeRuntimeConfiguration"/>
@@ -47,6 +51,8 @@ public NativeRuntimeConfiguration()
             if (!File.Exists(filePath)) throw new FileNotFoundException("The runner executable file does not exist or cannot be found", filePath);
             this.Executable = env;
         }
+        env = Environment.GetEnvironmentVariable(SynapseDefaults.EnvironmentVariables.Runtime.Native.SecretsDirectory);
+        if (!string.IsNullOrWhiteSpace(env)) this.SecretsDirectory = env;
     }
 
     /// <summary>
@@ -61,5 +67,10 @@ public NativeRuntimeConfiguration()
     [DataMember(Order = 2, Name = "executable"), JsonPropertyOrder(2), JsonPropertyName("executable"), YamlMember(Order = 2, Alias = "executable")]
     public virtual string Executable { get; set; } = DefaultExecutable;
 
+    /// <summary>
+    /// Gets/sets the path to the directory that contains the secrets made available to runners
+    /// </summary>
+    [DataMember(Order = 3, Name = "secretsDirectory"), JsonPropertyOrder(3), JsonPropertyName("secretsDirectory"), YamlMember(Order = 3, Alias = "secretsDirectory")]
+    public virtual string SecretsDirectory { get; set; } = DefaultSecretsDirectory;
 
 }

src/core/Synapse.Core/Resources/TaskInstance.cs

@@ -24,7 +24,7 @@ public record TaskInstance
     /// Gets the task's id
     /// </summary>
     [DataMember(Name = "id", Order = 1), JsonPropertyName("id"), JsonPropertyOrder(1), YamlMember(Alias = "id", Order = 1)]
-    public virtual string Id { get; set; } = Guid.NewGuid().ToString("N")[..15];
+    public virtual string Id { get; set; } = Guid.NewGuid().ToString("N")[..12];
 
     /// <summary>
     /// Gets the task's name, if any

src/core/Synapse.Core/SynapseDefaults.cs

@@ -562,6 +562,14 @@ public static class Runner
             /// Gets the environment variable used to configure whether or not runners should publish lifecycle events
             /// </summary>
             public const string LifecycleEvents = Prefix + "LIFECYCLE_EVENTS";
+            /// <summary>
+            /// Gets the environment variable used to configure the runner's namespace
+            /// </summary>
+            public const string Namespace = Prefix + "NAMESPACE";
+            /// <summary>
+            /// Gets the environment variable used to configure the runner's name
+            /// </summary>
+            public const string Name = Prefix + "NAME";
 
         }
 
@@ -740,6 +748,10 @@ public static class Native
                 /// Gets the environment variable used to configure the path to the runner's executable file
                 /// </summary>
                 public const string Executable = Prefix + "EXECUTABLE";
+                /// <summary>
+                /// Gets the environment variable used to configure the directory that contains the secrets made available to runners
+                /// </summary>
+                public const string SecretsDirectory = Prefix + "SECRETS_DIRECTORY";
 
             }