fix(Runner): Fixed the WorkflowDefinitionExtensions and DoTaskDefinitionExtensions to rely on name to determine the next task, instead of relying of task record equality, which resulted in wrong resolution when the task had similar properties

Fixes #485

Signed-off-by: Charles d'Avernas <charles.davernas@neuroglia.io>

Author: cdavernas

src/runner/Synapse.Runner/Extensions/DoTaskDefinitionExtensions.cs

@@ -31,8 +31,7 @@ public static class DoTaskDefinitionExtensions
         switch (after.Next)
         {
             case FlowDirective.Continue:
-                var afterTask = doTask.Do[after.Name!];
-                var afterIndex = doTask.Do.Select(t => t.Value).ToList().IndexOf(afterTask);
+                var afterIndex = doTask.Do.Select(t => t.Key).ToList().IndexOf(after.Name!);
                 return doTask.Do.Skip(afterIndex + 1).FirstOrDefault();
             case FlowDirective.End: case FlowDirective.Exit: return default;
             default: return new(after.Next!, doTask.Do[after.Next!]);

src/runner/Synapse.Runner/Extensions/WorkflowDefinitionExtensions.cs

@@ -31,8 +31,7 @@ public static class WorkflowDefinitionExtensions
         switch (after.Status == TaskInstanceStatus.Skipped ? FlowDirective.Continue : after.Next)
         {
             case FlowDirective.Continue:
-                var afterTask = workflow.Do[after.Name!];
-                var afterIndex = workflow.Do.Select(e => e.Value).ToList().IndexOf(afterTask);
+                var afterIndex = workflow.Do.Select(kvp => kvp.Key).ToList().IndexOf(after.Name!);
                 return workflow.Do.Skip(afterIndex + 1).FirstOrDefault();
             case FlowDirective.End: case FlowDirective.Exit: return default;
             default: return new(after.Next!, workflow.Do[after.Next!]);

src/runner/Synapse.Runner/Services/ConnectedWorkflowExecutionContext.cs

@@ -123,7 +123,7 @@ public virtual async Task<TaskInstance> CreateTaskAsync(TaskDefinition definitio
         }
         else
         {
-            var contextDocument = await this.Documents.CreateAsync($"{reference}/input", context, cancellationToken).ConfigureAwait(false);
+            var contextDocument = await this.Documents.CreateAsync($"{reference}/context", context, cancellationToken).ConfigureAwait(false);
             contextReference = contextDocument.Id;
         }
         var filteredInput = input;