Skip to content

Commit 8b759d9

Browse files
committed
Triage 24 commits
1 parent b6fbc1a commit 8b759d9

File tree

2 files changed

+42
-24
lines changed

2 files changed

+42
-24
lines changed

commits.txt

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ https://github.com/servo/servo/pull/40462 (@Taym95, #40462) WebGLBuffer: follow
395395
# This change is preparation for fixing #22550 and implementing
396396
# off-the-main-thread CSS parsing.
397397
# Testing: This should not change any behavior so is covered by existing tests.
398-
https://github.com/servo/servo/pull/40453 (@mrobinson, @mukilan, #40453) net: Use callbacks instead of IPC channels in the `ImageCache` API (#40453)
398+
-https://github.com/servo/servo/pull/40453 (@mrobinson, @mukilan, #40453) net: Use callbacks instead of IPC channels in the `ImageCache` API (#40453)
399399
# Previously, the `ImageCache` would inform consumers of changes to image
400400
# availability by messaging an IPC channel. This isn't great, because it
401401
# requires serialization and deserialization. Nowadays, `ImageCache`s are
@@ -476,7 +476,7 @@ https://github.com/servo/servo/pull/40429 (@mrobinson, @mukilan, #40429) script:
476476
# [this](https://hg-edge.mozilla.org/mozilla-central/file/tip/testing/webdriver/src/server.rs#l84). There is also no
477477
# way to override [Dispatcher](https://hg-edge.mozilla.org/mozilla-central/file/tip/testing/webdriver/src/server.rs#l65).
478478
# A follow up PR which changes wptrunner to gracefully shutdown servo without killing depends on this.
479-
https://github.com/servo/servo/pull/40445 (@yezhizhen, #40445) webdriver: Remove session requirement from Shutdown command (#40445)
479+
-https://github.com/servo/servo/pull/40445 (@yezhizhen, #40445) webdriver: Remove session requirement from Shutdown command (#40445)
480480
# Change API endpoint from "/session/{sessionId}/servo/shutdown" to "/servo/shutdown", similar to [Status
481481
# command](https://w3c.github.io/webdriver/#dfn-status).
482482
# This will make it much easier to shutdown Servo properly from wptrunner.
@@ -863,7 +863,7 @@ https://github.com/servo/servo/pull/40411 (@simonwuelker, #40411) xpath: Handle
863863
# This removes some unneeded lints, especially `#[allow(unsafe_code)]`.
864864
# Testing: Refactor
865865
# Part of: #40383
866-
https://github.com/servo/servo/pull/40393 (@yezhizhen, #40393) Reduce unnecessary type conversion and share `WebDriverCommandMsg::LoadUrl` handler across platform (#40393)
866+
-https://github.com/servo/servo/pull/40393 (@yezhizhen, #40393) Reduce unnecessary type conversion and share `WebDriverCommandMsg::LoadUrl` handler across platform (#40393)
867867
# - Reduces unnecessary type conversion between `ServoUrl`, `Url`, string slice
868868
# - Share `WebDriverCommandMsg::LoadUrl` handler across platform
869869
# Testing: Covered by existing test. Manually tested for OHOS.
@@ -1321,13 +1321,13 @@ https://github.com/servo/servo/pull/40489 (@eerii, #40489) tools: Remove wrapped
13211321
# `into_string()` copies the whole url into a new string.
13221322
# Signed-off-by: Narfinger
13231323
# Testing: Should not change any functionality.
1324-
https://github.com/servo/servo/pull/40538 (@atbrakhi, #40538) servoshell: Move `webdriver_receiver` to shared base (#40538)
1324+
-https://github.com/servo/servo/pull/40538 (@atbrakhi, #40538) servoshell: Move `webdriver_receiver` to shared base (#40538)
13251325
# This PR eliminates duplicate code while maintaining the same functionality across all platforms.. We move
13261326
# `webdriver_receiver` to shared base where `webdriver_sender` lives
13271327
# Testing: No functional changes. Existing tests should test this.
13281328
# Fixes: Part of https://github.com/servo/servo/issues/40530
13291329
-https://github.com/servo/servo/pull/40537 (@Narfinger, #40537) script_bindings: Small USVString cleanup (#40537)
1330-
https://github.com/servo/servo/pull/40534 (@atbrakhi, #40534) servoshell: Move screenshot stability tracking to shared base (#40534)
1330+
-https://github.com/servo/servo/pull/40534 (@atbrakhi, #40534) servoshell: Move screenshot stability tracking to shared base (#40534)
13311331
# Move screenshot stability tracking to shared base. This PR eliminates duplicate code while maintaining the same
13321332
# functionality across all platforms.
13331333
# Testing: No functional changes. Existing tests should test this.
@@ -1877,7 +1877,7 @@ https://github.com/servo/servo/pull/40590 (@mrobinson, #40590) script: Use `Scri
18771877
# This change is preparation for splitting out the creation of a new
18781878
# `ScriptThread` and the spawning of its first pipeline.
18791879
# Testing: This should not change observable behavior, so is covered by existing tests.
1880-
https://github.com/servo/servo/pull/40595 (@nicoburns, #40595) Bump html5ever to 0.36.1, stylo to f319793 (#40595)
1880+
-https://github.com/servo/servo/pull/40595 (@nicoburns, #40595) Bump html5ever to 0.36.1, stylo to f319793 (#40595)
18811881
# The versions of html5ever were bumped due to a breaking change to the `web_atoms` crate initially being published
18821882
# under the wrong version number.
18831883
# Testing: not required as the code is identical, only version numbers have changed.
@@ -2556,7 +2556,7 @@ https://github.com/servo/servo/pull/40593 (@simonwuelker, #40593) xpath: Handle
25562556
# - html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm
25572557
# - html/semantics/embedded-content/media-elements/seeking/seek-to-negative-time.htm
25582558
# Fixes: https://github.com/servo/servo/issues/34496
2559-
https://github.com/servo/servo/pull/40508 (@Taym95, #40508) Add AbortSignal garbage collection (#40508)
2559+
-https://github.com/servo/servo/pull/40508 (@Taym95, #40508) Add AbortSignal garbage collection (#40508)
25602560
# Add AbortSignal garbage collection
25612561
# Testing: all AbortSignal should pass.
25622562
# Fixes: #40481
@@ -2659,7 +2659,7 @@ https://github.com/servo/servo/pull/40616 (@TimvdLippe, #40616) Implement protoc
26592659
# Testing: Refactoring. Existing tests suffice.
26602660
-https://github.com/servo/servo/pull/40642 (@kkoyung, #40642) wpt: Remove legacy expectation (#40642)
26612661
# These WPT tests on WebCrypto API were either renamed or removed. We can safely remove these legacy test expectations
2662-
https://github.com/servo/servo/pull/40629 (@kongbai1996, #40629) Add scroll and fling trace. (#40629)
2662+
-https://github.com/servo/servo/pull/40629 (@kongbai1996, #40629) Add scroll and fling trace. (#40629)
26632663
# Add scroll and fling trace.
26642664
# Testing: There are no related tests available for now; we will add a test item for frame rate statistics on CI later.
26652665
# Fixes: NA
@@ -2854,7 +2854,8 @@ https://github.com/servo/servo/pull/40762 (@simonwuelker, #40762) script: Don't
28542854
# panicking on a few instead.
28552855
# Testing: This change adds a simple crashtest
28562856
# Fixes: https://github.com/servo/servo/issues/40719
2857-
https://github.com/servo/servo/pull/40768 (@simonwuelker, #40768) script: Add messages to exceptions thrown in Element::attachShadow (#40768)
2857+
+https://github.com/servo/servo/pull/40768 (@simonwuelker, #40768) script: Add messages to exceptions thrown in Element::attachShadow (#40768)
2858+
dom; exception messages
28582859
# Part of https://github.com/servo/servo/issues/40756
28592860
https://github.com/servo/servo/pull/40433 (@mrobinson, #40433) paint: Do trigger animations when a non-animation paint happens (#40433)
28602861
# Otherwise the `RefreshObsever` can get wedged. This does mean that we
@@ -3053,7 +3054,8 @@ https://github.com/servo/servo/pull/40736 (@mrobinson, #40736) webgl: Ensure all
30533054
# crashes on the CI.
30543055
# Fixes: #40399.
30553056
# Fixes: #40417.
3056-
https://github.com/servo/servo/pull/40725 (@mrobinson, #40725) script: Use a `WeakRef` for references to `WebGLRenderingContext` (#40725)
3057+
+https://github.com/servo/servo/pull/40725 (@mrobinson, #40725) script: Use a `WeakRef` for references to `WebGLRenderingContext` (#40725)
3058+
security; fix use-after-free in WebGL
30573059
# Many WebGL objects refer to a `WebGLRenderingContext` and rely on it for
30583060
# messaging to the `WebGLThread`. This poses a problem, because WebGL
30593061
# objects often need to send a message to the `WebGLThread` during their
@@ -3211,7 +3213,8 @@ https://github.com/servo/servo/pull/40712 (@mrobinson, #40712) libservo: Trigger
32113213
# should cause a box rebuild. This change does that, hopefully fixing
32123214
# flaky tests.
32133215
# Testing: This doesn't have any test changes, but should fix the test situation described in #40419.
3214-
https://github.com/servo/servo/pull/40578 (@rayguo17, #40578) Media: Display User Agent Controls widget for video element. (#40578)
3216+
+https://github.com/servo/servo/pull/40578 (@rayguo17, #40578) Media: Display User Agent Controls widget for video element. (#40578)
3217+
layout; UA controls for <video> (was previously supported for <audio>)
32153218
# Add Contents::ReplacedWithWidget for video elements with UA control widget, to allow Traverse into the children
32163219
# of video element during Box Tree Construction, Generate IndependentFormattingContextContent::ReplacedWithWidgets,
32173220
# to store both the `ReplacedContents` and `BlockFormattingContext`. During fragment tree generation process, first
@@ -3499,7 +3502,7 @@ https://github.com/servo/servo/pull/40666 (@arihant2math, @yezhizhen, #40666) in
34993502
# Testing: It's just refactoring
35003503
# try run: https://github.com/sagudev/servo/actions/runs/19287700927
35013504
>>> 2025-11-22T07:09:34Z
3502-
https://github.com/servo/servo/pull/40784 (@yezhizhen, #40784) webdriver: Generalize `implicit_wait` (#40784)
3505+
-https://github.com/servo/servo/pull/40784 (@yezhizhen, #40784) webdriver: Generalize `implicit_wait` (#40784)
35033506
# I wanted to implement [implicit wait](https://w3c.github.io/webdriver/#dfn-implicit-wait-timeout) for other
35043507
# commands, such as send key/element clear/click. But the current trait bound, parameters, and logic are way too
35053508
# tight and specific.
@@ -3508,7 +3511,7 @@ https://github.com/servo/servo/pull/40784 (@yezhizhen, #40784) webdriver: Genera
35083511
# Partial fix for https://github.com/servo/servo/issues/40744
35093512
# Testing: Refactor covered by existing tests.
35103513
# Fixes: Contributes to https://github.com/servo/servo/issues/40744
3511-
https://github.com/servo/servo/pull/40804 (@Loirooriol, #40804) compositing_traits: Drop unnecessary variable mutability (#40804)
3514+
-https://github.com/servo/servo/pull/40804 (@Loirooriol, #40804) compositing_traits: Drop unnecessary variable mutability (#40804)
35123515
# This avoids a warning when compiling tests.
35133516
# Testing: Not needed, no behavior change
35143517
+https://github.com/servo/servo/pull/40797 (@Loirooriol, @mrobinson, #40797) layout: Preserve cached layout results of undamaged descendants (#40797)
@@ -3522,7 +3525,8 @@ https://github.com/servo/servo/pull/40804 (@Loirooriol, #40804) compositing_trai
35223525
# damage. However, intrinsic sizes don't depend on ancestors for the most part, so now we will only clear the cache
35233526
# if the relayout damage is in the element or a descendant.
35243527
# Testing: Not needed, no change in behavior
3525-
https://github.com/servo/servo/pull/40794 (@mrobinson, #40794) libservo: Have `WebView` take a `RenderingContext` rather than `Servo` (#40794)
3528+
+https://github.com/servo/servo/pull/40794 (@mrobinson, #40794) libservo: Have `WebView` take a `RenderingContext` rather than `Servo` (#40794)
3529+
api; per-webview rendering contexts (big part of support for multiple windows)
35263530
# This is the last major change before we can try to implement support for
35273531
# multiple windows in Servo. This change makes it so that each `WebView`
35283532
# (via `WebViewBuilder`) takes the `RenderingContext` as an argument,
@@ -3559,7 +3563,7 @@ https://github.com/servo/servo/pull/40653 (@TimvdLippe, #40653) libservo: Notify
35593563
# or window, so this change just removes it entirely.
35603564
# Testing: This should make the main loop of headless servoshell more efficient,
35613565
# but I do not think this difference is going to be observable in any way.
3562-
https://github.com/servo/servo/pull/40792 (@mrobinson, #40792) servoshell: Move `Minibrowser` to headed window (#40792)
3566+
-https://github.com/servo/servo/pull/40792 (@mrobinson, #40792) servoshell: Move `Minibrowser` to headed window (#40792)
35633567
# Instead of storing the `Minibrowser` egui struct in the
35643568
# `RunningAppState` which is used for both headed and headless windows,
35653569
# move it to the headed window implementation. This addresses a lot of
@@ -3579,7 +3583,7 @@ https://github.com/servo/servo/pull/40788 (@mukilan, @mrobinson, #40788) composi
35793583
# `PainterId` or `WebViewId`.
35803584
# This change is to enable support for per-`WebView`s `RenderingContext`s.
35813585
# Testing: This change shouldn't change behavior, so existing WPT tests should cover it.
3582-
https://github.com/servo/servo/pull/40766 (@atbrakhi, #40766) servoshell: Share WebView management between desktop and EGL platforms (#40766)
3586+
-https://github.com/servo/servo/pull/40766 (@atbrakhi, #40766) servoshell: Share WebView management between desktop and EGL platforms (#40766)
35833587
# Desktop and EGL implementations were maintaining identical WebView collection logic (HashMap, creation order
35843588
# tracking, focus management).
35853589
# Extracted this into a shared WebViewCollection struct in RunningAppStateBase. Both platforms now use the common
@@ -3631,7 +3635,8 @@ https://github.com/servo/servo/pull/40647 (@simonwuelker, #40647) fonts: Compute
36313635
# }
36323636
# The hackfest
36333637
# ```
3634-
https://github.com/servo/servo/pull/40821 (@nicoburns, #40821) Upgrade Taffy to v0.9.2 (#40821)
3638+
+https://github.com/servo/servo/pull/40821 (@nicoburns, #40821) Upgrade Taffy to v0.9.2 (#40821)
3639+
crash; fix panic in grid layout
36353640
# Upgrades the patch version of Taffy (release notes: https://github.com/DioxusLabs/taffy/releases/tag/v0.9.2)
36363641
# Testing: WPT tests
36373642
# Fixes https://github.com/servo/servo/issues/40730
@@ -3662,14 +3667,14 @@ https://github.com/servo/servo/pull/40817 (@jdm, #40817) testing: Remove ahem.cs
36623667
# holdover from this. This change renames this struct to `Gui` to better
36633668
# reflect what it does.
36643669
# Testing: This just renames some data structures, so should not need new tests.
3665-
https://github.com/servo/servo/pull/40787 (@eerii, #40787) devtools: Add Environment actor boilerplate and Object actor encode (#40787)
3670+
-https://github.com/servo/servo/pull/40787 (@eerii, #40787) devtools: Add Environment actor boilerplate and Object actor encode (#40787)
36663671
# Prequisite for implementing pausing in the debugger. The `EnvironmentActor` will be used in the future from the
36673672
# `FrameActor`, we need the struct defined to start to implement it.
36683673
# The `ObjectActorMsg` is not only used by the `EnvoironmentActor`, but also by the `ThreadActor` when replying to
36693674
# `interrupt`.
36703675
# Testing: Deferred until the pause is fully implemented.
36713676
# Fixes: Part of #36027.
3672-
https://github.com/servo/servo/pull/40786 (@eerii, #40786) devtools: Pause actor boilerplate (#40786)
3677+
-https://github.com/servo/servo/pull/40786 (@eerii, #40786) devtools: Pause actor boilerplate (#40786)
36733678
# Prequisite for implementing pausing in the debugger. This will be part of the `ThreadActor` response to `interrupt`. I
36743679
# decided to split the change in multiple patches since it is quite big. Continuation of #38824.
36753680
# Testing: Deferred until the pause is fully implemented.
@@ -3689,7 +3694,7 @@ https://github.com/servo/servo/pull/40811 (@jdm, #40811) script: Improve spec-co
36893694
# Fixes: #40808
36903695
+https://github.com/servo/servo/pull/40692 (@jdm, #40692) Run SVG tests in CI. (#40692)
36913696
# Now that we have rudimentary SVG support, we should probably run the testsuite.
3692-
https://github.com/servo/servo/pull/40806 (@yezhizhen, #40806) openxr: Fix DirectX 11 build warning and reduce visiblity (#40806)
3697+
-https://github.com/servo/servo/pull/40806 (@yezhizhen, #40806) openxr: Fix DirectX 11 build warning and reduce visiblity (#40806)
36933698
# This mod is only compiled for Win therefore hasn't been captured by Lint.
36943699
-https://github.com/servo/servo/pull/40809 (@kkoyung, #40809) script: Rename `ExportedKey::Raw` to `ExportedKey::Bytes` (#40809)
36953700
# The enum variant `ExportedKey::Raw(Vec)` is actually used when a key is exported in "raw", "spki" or "pkcs8"
@@ -3722,7 +3727,7 @@ https://github.com/servo/servo/pull/40806 (@yezhizhen, #40806) openxr: Fix Direc
37223727
# a rebase manually by commenting `@dependabot rebase`.
37233728
# [//]: # (dependabot-automerge-start)
37243729
# [//]: # (dependabot-automerge-end)
3725-
https://github.com/servo/servo/pull/40791 (@eerii, #40791) devtools: Frame actor boilerplate (#40791)
3730+
-https://github.com/servo/servo/pull/40791 (@eerii, #40791) devtools: Frame actor boilerplate (#40791)
37263731
# Prequisite for implementing pausing in the debugger. This will be part of the `ThreadActor` response to
37273732
# `interrupt`. Continuation of #38824.
37283733
# Depends on #40787 for `EnvironmentActor*`.
@@ -3965,7 +3970,7 @@ https://github.com/servo/servo/pull/40301 (@jdm, @uthmaniv, #40301) fonts: Add W
39653970
# changes means that this fix will only have to happen in one place
39663971
# instead of two.
39673972
# Testing: This should not change behavior and thus is covered by existing tests.
3968-
https://github.com/servo/servo/pull/40812 (@jdm, #40812) script: Replace strings for performance entry types with dedicated enum. (#40812)
3973+
-https://github.com/servo/servo/pull/40812 (@jdm, #40812) script: Replace strings for performance entry types with dedicated enum. (#40812)
39693974
# This both reduces unnecessary string comparisons and fixes several cases where two string arguments were passed
39703975
# in the wrong order.
39713976
# Depends on https://github.com/servo/servo/pull/40811.
@@ -4009,7 +4014,8 @@ https://github.com/servo/servo/pull/40852 (@delan, #40852) ci: Use new queue API
40094014
# [4](https://github.com/servo/servo/actions/runs/19624564171),
40104015
# [5](https://github.com/servo/servo/actions/runs/19624566167),
40114016
# [6](https://github.com/servo/servo/actions/runs/19624568092)
4012-
https://github.com/servo/servo/pull/40842 (@Taym95, #40842) Implement brotli support for CompressionStream and DecompressionStream (#40842)
4017+
+https://github.com/servo/servo/pull/40842 (@Taym95, #40842) Implement brotli support for CompressionStream and DecompressionStream (#40842)
4018+
dom; new CompressionStream("brotli") and new DecompressionStream("brotli")
40134019
# Implement brotli support for CompressionStream and DecompressionStream
40144020
# Testing: brotli test should pass
40154021
# Fixes: #40831
@@ -4343,7 +4349,7 @@ https://github.com/servo/servo/pull/40875 (@tharkum, #40875) html: Use WeakRef f
43434349
# Addresses part of https://github.com/servo/servo/issues/34573
43444350
-https://github.com/servo/servo/pull/40874 (@yezhizhen, #40874) Fix compilation warning for `background_hang_monitor` (#40874)
43454351
# Fix warnings exposed by 0a0a20a9c6b7983ed96fb86715ada5b9f6d61f2e
4346-
https://github.com/servo/servo/pull/40872 (@yezhizhen, #40872) Remove unnecessary clones in various places (#40872)
4352+
-https://github.com/servo/servo/pull/40872 (@yezhizhen, #40872) Remove unnecessary clones in various places (#40872)
43474353
# Testing: This should not change anything. Still, things have to build.
43484354
>>> 2025-11-27T06:15:41Z
43494355
-https://github.com/servo/servo/pull/40910 (@dependabot[bot], @dependabot[bot], #40910) build(deps): bump tracing-attributes from 0.1.30 to 0.1.31 (#40910)

0 commit comments

Comments
 (0)