Commit 25e4639
Keep workspace:* protocol in react-on-rails-pro package.json (#2177)
## Summary
- Removes unnecessary manual conversion of `workspace:*` to explicit
version during release
- Restores `workspace:*` in `packages/react-on-rails-pro/package.json`
Fixes #2176
## Details
The release script (`rakelib/release.rake`) was manually converting
`workspace:*` to an explicit version in
`packages/react-on-rails-pro/package.json` during release. This is
**unnecessary** because pnpm automatically handles this conversion
during `pnpm publish`.
### How pnpm handles workspace:*
When running `pnpm pack` or `pnpm publish`, pnpm dynamically replaces
`workspace:*` with the corresponding version. This is documented
behavior: https://pnpm.io/workspaces
### Verified locally
```bash
# 1. Set dependency to workspace:*
# 2. Run pnpm pack
# 3. Extract tarball's package.json
# Result: "react-on-rails": "16.2.0-beta.13" (exact version)
```
### Benefits
- **Cleaner development experience** - Developers see `workspace:*`
indicating a workspace dependency
- **No spurious git changes** - The dependency line won't change on
every release
- **pnpm best practice** - Let the tool handle what it's designed for
- **Simpler release script** - Less code to maintain
## Test plan
- [x] Verified `pnpm pack` converts `workspace:*` to exact version in
tarball
- [x] Confirmed published package.json in tarball has correct version
🤖 Generated with [Claude Code](https://claude.com/claude-code)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Chores**
* Simplified dependency management and release process for internal
packages by streamlining version handling during builds.
<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Claude <noreply@anthropic.com>1 parent b3d0430 commit 25e4639
2 files changed
+4
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
| 199 | + | |
| 200 | + | |
205 | 201 | | |
206 | 202 | | |
207 | 203 | | |
| |||
340 | 336 | | |
341 | 337 | | |
342 | 338 | | |
343 | | - | |
| 339 | + | |
344 | 340 | | |
345 | 341 | | |
346 | 342 | | |
| |||
0 commit comments