From d1467990131f78b511811399f36ff2e73ff20c62 Mon Sep 17 00:00:00 2001 From: Sam Douglas Date: Tue, 8 Jul 2025 15:31:47 +1200 Subject: [PATCH 1/4] update ci workflow actions --- .github/workflows/ci.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d83c3e5..b4284af6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -16,30 +16,30 @@ jobs: runs-on: ubuntu-latest steps: - name: Set up Go 1.17 - uses: actions/setup-go@v2 + uses: actions/setup-go@v5 with: go-version: 1.17 - name: Set Go cache paths id: go-cache-paths run: | - echo "::set-output name=go-build::$(go env GOCACHE)" - echo "::set-output name=go-mod::$(go env GOMODCACHE)" + echo "name=go-build::$(go env GOCACHE)" >> $GITHUB_OUTPUT + echo "name=go-mod::$(go env GOMODCACHE)" >> $GITHUB_OUTPUT - name: Go Build Cache - uses: actions/cache@v2 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-build }} key: ${{ runner.os }}-go-build-${{ hashFiles('**/go.sum') }} - name: Go Mod Cache - uses: actions/cache@v2 + uses: actions/cache@v4 with: path: ${{ steps.go-cache-paths.outputs.go-mod }} key: ${{ runner.os }}-go-mod-${{ hashFiles('**/go.sum') }} - name: Checkout the code - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Run tests working-directory: ./kibble From 2bc95f1ec508c6b11e1013534a924b865aebafbc Mon Sep 17 00:00:00 2001 From: Sam Douglas Date: Tue, 8 Jul 2025 15:35:12 +1200 Subject: [PATCH 2/4] quotes around $github_output ? --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b4284af6..d24dee4b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: - name: Set Go cache paths id: go-cache-paths run: | - echo "name=go-build::$(go env GOCACHE)" >> $GITHUB_OUTPUT - echo "name=go-mod::$(go env GOMODCACHE)" >> $GITHUB_OUTPUT + echo "name=go-build::$(go env GOCACHE)" >> "$GITHUB_OUTPUT" + echo "name=go-mod::$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" - name: Go Build Cache uses: actions/cache@v4 From ecbc8b014b90a97e8d9edd0a4ceef2e728d087bb Mon Sep 17 00:00:00 2001 From: Sam Douglas Date: Tue, 8 Jul 2025 15:39:23 +1200 Subject: [PATCH 3/4] fix? output syntax properly --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d24dee4b..30d21022 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,8 +23,8 @@ jobs: - name: Set Go cache paths id: go-cache-paths run: | - echo "name=go-build::$(go env GOCACHE)" >> "$GITHUB_OUTPUT" - echo "name=go-mod::$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" + echo "go-build=$(go env GOCACHE)" >> "$GITHUB_OUTPUT" + echo "go-mod=$(go env GOMODCACHE)" >> "$GITHUB_OUTPUT" - name: Go Build Cache uses: actions/cache@v4 From d163a9efd2756485d3f76032c3e4ae9d61cde4fe Mon Sep 17 00:00:00 2001 From: Sam Douglas Date: Tue, 8 Jul 2025 15:42:54 +1200 Subject: [PATCH 4/4] update the release workflow too maybe? --- .github/workflows/publish-release.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index 6aa799ee..85e139a5 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -12,7 +12,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: '16.x' - name: Ensure kibble-npm package version matches the tag @@ -30,12 +30,12 @@ jobs: name: Lint runs-on: ubuntu-latest steps: - - uses: actions/setup-go@v3 + - uses: actions/setup-go@v5 with: go-version: 1.18 - uses: actions/checkout@v4 - name: golangci-lint - uses: golangci/golangci-lint-action@v3 + uses: golangci/golangci-lint-action@v4 with: # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version version: v1.48.0 @@ -50,7 +50,7 @@ jobs: with: fetch-depth: 0 - name: Set up Go - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: 1.18 - name: Run tests @@ -67,7 +67,7 @@ jobs: with: fetch-depth: 0 - name: Set up Go - uses: actions/setup-go@v4 + uses: actions/setup-go@v5 with: go-version: 1.18 - name: Install GoReleaser @@ -90,7 +90,7 @@ jobs: steps: - name: Checkout uses: actions/checkout@v4 - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: node-version: '16.x' registry-url: "https://registry.npmjs.org"