[BUG] [COMPOSABLES] isListPrice calculation is wrong

[bylmzio]

i came across this isListPrice computed property while i was implementing discounts.

Listprice from my understanding should be true if there is no discount.
This means either listprice is not set or if lets say if listprice equals unitprice then percentage is 0
Bug lies here:

packages/composables/src/useProductPrice/useProductPrice.ts

  const isListPrice: ComputedRef<boolean> = computed(() => {
    return !!_price.value?.listPrice?.percentage;
  });

My suggested bugfix would be.

  const isListPrice: ComputedRef<boolean> = computed(() => {
    return !_price.value?.listPrice?.percentage;
  });

But this opens alot of questions for the currents tests.

[mdanilowicz]

Hi Bünyamin Yilmaz (@bylmzio), thanks for creating the issue

listPrice determines whether a promotion is available. To obtain a boolean value, we use double negation (!!).
I agree that the name is misleading, so I changed it to hasListPrice. MR: #2318

Let me know if you still have any doubts about this variable