- Merged PR#28 on behalf of @igaryhe

  Don't get the new part name every time when iterating over old parts when updating the GeoNode.
- Fixed Issue #29 on behalf of @ValentinBessonKlang
  Fixed typo in SetStringParameterValue that caused null refs exceptions.
- Fixed Issue #24 on behalf of @tgaldi
  HDRP Terrain Detail incorrectly set for Unity 2021/2022
- Fixed issue #13:
  Input interfaces' priorities were incorrectly used when registering input interface.

Author: dpernuit

Plugins/HoudiniEngineUnity/Scripts/Asset/HEU_GeoNode.cs

@@ -484,16 +484,17 @@ internal void UpdateGeo(HEU_SessionBase session)
                             continue;
                         }
 
+                        string partName = HEU_SessionManager.GetString(partInfo.nameSH, session);
+
                         // Find the old part for this new part.
                         HEU_PartData part = null;
                         HEU_PartData oldMatchedPart = null;
-
                         foreach (HEU_PartData oldPart in oldParts)
                         {
-                            string partName = HEU_SessionManager.GetString(partInfo.nameSH, session);
                             if (oldPart.PartName.Equals(partName))
                             {
                                 oldMatchedPart = oldPart;
+                                break;
                             }
                         }
 

Plugins/HoudiniEngineUnity/Scripts/Parameters/HEU_Parameters.cs

@@ -822,7 +822,7 @@ public bool SetStringParameterValues(string parameterName, string[] values, bool
             }
 
             // Copy by value
-            for (int i = 0; i < paramData._intValues.Length; i++)
+            for (int i = 0; i < paramData._stringValues.Length; i++)
             {
                 paramData._stringValues[i] = values[i];
             }

Plugins/HoudiniEngineUnity/Scripts/Utility/HEU_InputUtility.cs

@@ -80,7 +80,7 @@ public static void RegisterInputInterface(HEU_InputInterface inputInterface)
                     {
                         if (_inputInterfaces[i] != null && _inputInterfaces[i].Priority <= inputInterface.Priority)
                         {
-                            _inputInterfaces.Add(inputInterface);
+                            _inputInterfaces.Insert(i, inputInterface);
                             //HEU_Logger.LogFormat("Registered {0} at {1}. Total of {2}", inputInterface.GetType(), i, _inputInterfaces.Count);
                             break;
                         }

Plugins/HoudiniEngineUnity/Scripts/Utility/HEU_TerrainUtility.cs

@@ -1274,11 +1274,15 @@ public static void ApplyDetailLayers(Terrain terrain, TerrainData terrainData,
 
                 detailPrototype.renderMode = (DetailRenderMode)heuDetail._renderMode;
 
+#if UNITY_2021_2_OR_NEWER
+            if( detailPrototype.usePrototypeMesh )
+                detailPrototype.useInstancing = true;
+#endif
+
                 detailPrototypes.Add(detailPrototype);
             }
 
             // Set the DetailPrototypes
-
             if (detailPrototypes.Count > 0)
             {
                 terrainData.detailPrototypes = detailPrototypes.ToArray();
@@ -1290,6 +1294,11 @@ public static void ApplyDetailLayers(Terrain terrain, TerrainData terrainData,
                 terrainData.SetDetailLayer(0, 0, i, convertedDetailMaps[i]);
             }
 #endif
+
+#if UNITY_2022_2_OR_NEWER
+            // Force the detail scatter mode to instance until we add support support for the other scatter mode.
+            terrainData.SetDetailScatterMode( DetailScatterMode.InstanceCountMode );
+#endif
         }
 
 #if UNITY_2018_3_OR_NEWER