If notion gives "bookmark" as link title, change to the link url

Author: hatton

src/plugins/externalLinks.spec.ts

@@ -10,9 +10,9 @@ test("links turned into bookmarks", async () => {
   setLogLevel("debug");
   const results = await getMarkdown({
     type: "bookmark",
-    bookmark: { caption: [], url: "https://github.com/" },
+    bookmark: { caption: [], url: "https://github.com" },
   });
-  expect(results).toBe("[github.com](https://github.com)");
+  expect(results.trim()).toBe("[https://github.com](https://github.com)");
 });
 
 test("links inside callouts", async () => {

src/plugins/externalLinks.ts

@@ -5,7 +5,7 @@ export const standardExternalLinkConversion: IPlugin = {
   name: "standard external link conversion",
   linkModifier: {
     label: "standard external link conversion",
-    match: /\[([^\]]+)?\]\(http.*\)/,
+    match: /\[.*\]\(http.*\)/,
     convert: (context: IDocuNotionContext, markdownLink: string) => {
       const linkRegExp = /\[([^\]]+)?\]\((http.*)\)/;
       const match = linkRegExp.exec(markdownLink);
@@ -17,7 +17,7 @@ export const standardExternalLinkConversion: IPlugin = {
       }
       const label = match[1];
       const url = match[2];
-      if (label === "Bookmark") {
+      if (label === "bookmark") {
         const replacement = `[${url}](${url})`;
         warning(
           `[standardExternalLinkConversion] Found Notion "Bookmark" link. In Notion this would show as an embed. The best docu-notion can do at the moment is replace "Bookmark" with the actual URL: ${replacement}`

src/transform.ts

@@ -131,8 +131,9 @@ function doLinkFixes(
   markdown: string,
   config: IDocuNotionConfig
 ): string {
-  const linkRegExp = /\[([^\]]+)?\]\(\/?([^),^/]+)\)/g;
+  const linkRegExp = /\[.*\]\(.*\)/g;
 
+  console.log("markdown before link fixes", markdown);
   // if (pages && pages.length) {
   //   console.log(pages[0].matchesLinkId);
   //   console.log(docunotionContext.pages[0].matchesLinkId);
@@ -143,7 +144,7 @@ function doLinkFixes(
   let match: RegExpExecArray | null;
 
   while ((match = linkRegExp.exec(markdown)) !== null) {
-    const originalLinkMarkdown = match[0];
+    const originalLinkMarkdown = match[0]; // ?
     const originalLinkText = match[1] || "";
     const originalUrl = match[2];