Merge pull request #79 from simplesamlphp/feature/php8.3

Feature/php8.3

Author: tvdijen

.github/workflows/php.yml

@@ -19,9 +19,9 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php-version: ['8.2', '8.3', '8.4', '8.5']
+        php-version: ['8.3', '8.4', '8.5']
 
-    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.10.6
+    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_phplinter.yml@v1.11.0
     with:
       php-version: ${{ matrix.php-version }}
 
@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
 
-    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.10.6
+    uses: simplesamlphp/simplesamlphp-test-framework/.github/workflows/reusable_linter.yml@v1.11.0
     with:
       enable_eslinter: false
       enable_jsonlinter: true
@@ -45,15 +45,15 @@ jobs:
       fail-fast: false
       matrix:
         operating-system: [ubuntu-latest]
-        php-versions: ['8.2', '8.3', '8.4', '8.5']
+        php-versions: ['8.3', '8.4', '8.5']
 
     steps:
       - name: Setup PHP, with composer and extensions
         # https://github.com/shivammathur/setup-php
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
-          extensions: ctype, date, dom, filter, libxml, pcre, spl, xml, xmlreader
+          extensions: ctype, date, dom, filter, intl, libxml, pcre, sodium, spl, xml, xmlreader
           tools: composer
           ini-values: error_reporting=E_ALL
           coverage: pcov
@@ -107,15 +107,15 @@ jobs:
       fail-fast: true
       matrix:
         operating-system: [windows-latest]
-        php-versions: ['8.2', '8.3', '8.4', '8.5']
+        php-versions: ['8.3', '8.4', '8.5']
 
     steps:
       - name: Setup PHP, with composer and extensions
         # https://github.com/shivammathur/setup-php
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php-versions }}
-          extensions: ctype, date, dom, filter, libxml, pcre, spl, xml, xmlreader
+          extensions: ctype, date, dom, filter, intl, libxml, pcre, sodium, spl, xml, xmlreader
           tools: composer
           ini-values: error_reporting=E_ALL
           coverage: none
@@ -163,7 +163,7 @@ jobs:
           # Should be the higest supported version, so we can use the newest tools
           php-version: '8.5'
           tools: composer, composer-require-checker, composer-unused
-          extensions: ctype, date, dom, filter, libxml, pcre, spl, xml
+          extensions: ctype, date, dom, filter, intl, libxml, pcre, sodium, spl, xml
           coverage: none
 
       - name: Setup problem matchers for PHP
@@ -215,7 +215,7 @@ jobs:
         uses: shivammathur/setup-php@v2
         with:
           # Should be the lowest supported version
-          php-version: '8.2'
+          php-version: '8.3'
           extensions: ctype, date, dom, filter, libxml, pcre, spl, xml
           tools: composer
           coverage: none

composer.json

@@ -32,7 +32,7 @@
         }
     },
     "require": {
-        "php": "^8.2",
+        "php": "^8.3",
 
         "ext-bcmath": "*",
         "ext-date": "*",
@@ -47,7 +47,7 @@
         "simplesamlphp/composer-xmlprovider-installer": "~1.2"
     },
     "require-dev": {
-        "simplesamlphp/simplesamlphp-test-framework": "~1.10"
+        "simplesamlphp/simplesamlphp-test-framework": "~1.11"
     },
     "support": {
         "issues": "https://github.com/simplesamlphp/xml-common/issues",

src/XML/AbstractElement.php

@@ -25,7 +25,9 @@
  *
  * @package simplesamlphp/xml-common
  */
-abstract class AbstractElement implements SerializableElementInterface
+abstract class AbstractElement implements
+    SerializableElementInterface,
+    ElementInterface
 {
     use SerializableElementTrait;
 
@@ -34,7 +36,6 @@ abstract class AbstractElement implements SerializableElementInterface
      * Create a document structure for this element
      *
      * @param \DOMElement|null $parent The element we should append to.
-     * @return \DOMElement
      */
     public function instantiateParentElement(?DOMElement $parent = null): DOMElement
     {
@@ -117,7 +118,6 @@ public static function getOptionalAttribute(
      * Static method that processes a fully namespaced class name and returns the name of the class from it.
      *
      * @param string $class
-     * @return string
      */
     public static function getClassName(string $class): string
     {
@@ -129,8 +129,6 @@ public static function getClassName(string $class): string
 
     /**
      * Get the XML qualified name (prefix:name) of the element represented by this class.
-     *
-     * @return string
      */
     public function getQualifiedName(): string
     {
@@ -166,8 +164,6 @@ public static function getChildrenOfClass(DOMElement $parent): array
 
     /**
      * Get the namespace for the element.
-     *
-     * @return string|null
      */
     public static function getNamespaceURI(): ?string
     {
@@ -187,8 +183,6 @@ public static function getNamespaceURI(): ?string
 
     /**
      * Get the namespace-prefix for the element.
-     *
-     * @return string
      */
     public static function getNamespacePrefix(): string
     {
@@ -206,8 +200,6 @@ public static function getNamespacePrefix(): string
 
     /**
      * Get the local name for the element.
-     *
-     * @return string
      */
     public static function getLocalName(): string
     {
@@ -224,8 +216,6 @@ public static function getLocalName(): string
 
     /**
      * Whether the element may be normalized.
-     *
-     * @return bool
      */
     public static function getNormalization(): bool
     {
@@ -244,7 +234,6 @@ public static function getNormalization(): bool
      * Test if an object, at the state it's in, would produce an empty XML-element
      *
      * @codeCoverageIgnore
-     * @return bool
      */
     public function isEmptyElement(): bool
     {

src/XML/ArrayizableElementInterface.php

@@ -15,7 +15,6 @@ interface ArrayizableElementInterface
      * Create a class from an array
      *
      * @param array<string, mixed> $data
-     * @return static
      */
     public static function fromArray(array $data): static;
 

src/XML/Assert/ByteTrait.php

@@ -11,7 +11,6 @@
  */
 trait ByteTrait
 {
-    /** @var string */
     private static string $byte_regex = '/^
         (
             (

src/XML/Assert/DateTimeTrait.php

@@ -30,8 +30,6 @@ trait DateTimeTrait
      * * ss is a two-integer-digit numeral that represents the whole seconds;
      * * '.' s+ (if present) represents the fractional seconds;
      * * zzzzzz (if present) represents the timezone (as described below).
-     *
-     * @var string
      */
     private static string $datetime_regex = '/^
         -?

src/XML/Assert/DateTrait.php

@@ -21,8 +21,6 @@ trait DateTrait
      *
      * and the least upper bound of the interval is the timeline point represented (noncanonically) by:
      * '-' yyyy '-' mm '-' dd 'T24:00:00' zzzzzz?.
-     *
-     * @var string
      */
     private static string $date_regex  = '/^
         -?

src/XML/Assert/DayTrait.php

@@ -13,8 +13,6 @@ trait DayTrait
 {
     /**
      * Format: ---DD with optional timezone representation
-     *
-     * @var string
      */
     private static string $day_regex  = '/^
         ---

src/XML/Assert/DecimalTrait.php

@@ -11,7 +11,6 @@
  */
 trait DecimalTrait
 {
-    /** @var string */
     private static string $decimal_regex = '/^[+-]?((\d+(\.\d*)?)|(\.\d+))$/D';
 
 

src/XML/Assert/DoubleTrait.php

@@ -11,7 +11,6 @@
  */
 trait DoubleTrait
 {
-    /** @var string */
     private static string $double_regex = '/^
         (
             ([+-]?([0-9]+[.][0-9]*|[.][0-9]+)([e][+-]?[0-9]+)?)