ack comment

Author: waleedlatif1

apps/sim/hooks/queries/folders.test.ts

@@ -156,4 +156,22 @@ describe('folder optimistic top insertion ordering', () => {
     expect(optimisticFolder).toBeDefined()
     expect(optimisticFolder?.sortOrder).toBe(1)
   })
+
+  it('uses source parent scope when duplicate parentId is undefined', async () => {
+    const mutation = useDuplicateFolderMutation()
+
+    await mutation.onMutate({
+      workspaceId: 'ws-1',
+      id: 'folder-parent-match',
+      name: 'Duplicated with inherited parent',
+      // parentId intentionally omitted to mirror duplicate fallback behavior
+    })
+
+    const optimisticFolder = getOptimisticFolderByName('Duplicated with inherited parent') as
+      | { parentId: string | null; sortOrder: number }
+      | undefined
+    expect(optimisticFolder).toBeDefined()
+    expect(optimisticFolder?.parentId).toBe('parent-1')
+    expect(optimisticFolder?.sortOrder).toBe(1)
+  })
 })

apps/sim/hooks/queries/folders.ts

@@ -243,19 +243,20 @@ export function useDuplicateFolderMutation() {
 
       // Get source folder info if available
       const sourceFolder = previousFolders[variables.id]
+      const targetParentId = variables.parentId ?? sourceFolder?.parentId ?? null
       return {
         id: tempId,
         name: variables.name,
         userId: sourceFolder?.userId || '',
         workspaceId: variables.workspaceId,
-        parentId: variables.parentId ?? sourceFolder?.parentId ?? null,
+        parentId: targetParentId,
         color: variables.color || sourceFolder?.color || '#808080',
         isExpanded: false,
         sortOrder: getTopInsertionSortOrder(
           currentWorkflows,
           previousFolders,
           variables.workspaceId,
-          variables.parentId
+          targetParentId
         ),
         createdAt: new Date(),
         updatedAt: new Date(),