fix(security): redact malformed tool params

Author: TheodoreSpeaks

apps/sim/lib/workflows/credentials/credential-extractor.test.ts

@@ -184,4 +184,25 @@ describe('export sanitizer resource coverage', () => {
       { type: 'custom-tool', params: { token: null, query: null } },
     ])
   })
+
+  it.each([
+    ['string', 'plaintext-secret'],
+    ['array', ['plaintext-secret']],
+  ])('withholds malformed %s tool params', (_shape, params) => {
+    vi.mocked(getBlock).mockReturnValue({
+      name: 'Test',
+      description: '',
+      subBlocks: [{ id: 'field', title: 'Field', type: 'tool-input' }],
+      outputs: {},
+    } as never)
+
+    const sanitized = sanitizeWorkflowForSharing(
+      stateWithSubBlock('tool-input', [{ type: 'custom-tool', params }]),
+      { redactOpaqueCredentialInputs: true }
+    )
+
+    expect(sanitized.blocks?.b1?.subBlocks?.field?.value).toEqual([
+      { type: 'custom-tool', params: null },
+    ])
+  })
 })

apps/sim/lib/workflows/credentials/credential-extractor.ts

@@ -1,3 +1,4 @@
+import { isPlainRecord } from '@sim/utils/object'
 import { getToolInputParamConfigs } from '@/lib/workflows/search-replace/indexer'
 import { WORKFLOW_SEARCH_SUBBLOCK_RESOURCE_TYPES } from '@/lib/workflows/search-replace/resources/registry'
 import { setValueAtPath } from '@/lib/workflows/search-replace/value-walker'
@@ -290,6 +291,15 @@ function sanitizeToolInputValue(value: unknown, options: WorkflowSanitizationOpt
 
   let sanitizedValue: unknown = value
   tools.forEach((tool, toolIndex) => {
+    const storedTool = value[toolIndex]
+    if (!isPlainRecord(storedTool)) {
+      throw new Error(`Parsed tool input at index ${toolIndex} lost its object shape`)
+    }
+    if (storedTool.params != null && !isPlainRecord(storedTool.params)) {
+      sanitizedValue = setValueAtPath(sanitizedValue, [toolIndex, 'params'], null)
+      return
+    }
+
     const configs = getToolInputParamConfigs({ tool, toolIndex })
     const configByParamKey = new Map<
       string,