Skip to content

Commit d002c73

Browse files
committed
ack comments
1 parent e0ac39a commit d002c73

File tree

4 files changed

+7
-4
lines changed

4 files changed

+7
-4
lines changed

apps/sim/tools/zendesk/autocomplete_organizations.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,8 @@ export const zendeskAutocompleteOrganizationsTool: ToolConfig<
117117
success: true,
118118
output: {
119119
organizations,
120+
// /organizations/autocomplete uses offset pagination (page/per_page), not cursor pagination.
121+
// after_cursor is always null; use next_page URL or page param for subsequent pages.
120122
paging: {
121123
after_cursor: null,
122124
has_more: hasMore,

apps/sim/tools/zendesk/get_tickets.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,8 +138,7 @@ export const zendeskGetTicketsTool: ToolConfig<ZendeskGetTicketsParams, ZendeskG
138138
const queryParams = new URLSearchParams()
139139
queryParams.append('query', searchTerms.join(' '))
140140
queryParams.append('filter[type]', 'ticket')
141-
if (params.perPage) queryParams.append('page[size]', params.perPage)
142-
if (params.pageAfter) queryParams.append('after_cursor', params.pageAfter)
141+
appendCursorPaginationParams(queryParams, params)
143142

144143
return `${buildZendeskUrl(params.subdomain, '/search/export')}?${queryParams.toString()}`
145144
}

apps/sim/tools/zendesk/search.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { ToolConfig } from '@/tools/types'
22
import {
3+
appendCursorPaginationParams,
34
buildZendeskUrl,
45
extractCursorPagingInfo,
56
handleZendeskError,
@@ -90,8 +91,7 @@ export const zendeskSearchTool: ToolConfig<ZendeskSearchParams, ZendeskSearchRes
9091
const queryParams = new URLSearchParams()
9192
queryParams.append('query', params.query)
9293
queryParams.append('filter[type]', params.filterType)
93-
if (params.perPage) queryParams.append('page[size]', params.perPage)
94-
if (params.pageAfter) queryParams.append('after_cursor', params.pageAfter)
94+
appendCursorPaginationParams(queryParams, params)
9595

9696
const query = queryParams.toString()
9797
const url = buildZendeskUrl(params.subdomain, '/search/export')

apps/sim/tools/zendesk/search_users.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ export const zendeskSearchUsersTool: ToolConfig<
124124
success: true,
125125
output: {
126126
users,
127+
// /users/search uses offset pagination (page/per_page), not cursor pagination.
128+
// after_cursor is always null; use next_page URL or page param for subsequent pages.
127129
paging: {
128130
after_cursor: null,
129131
has_more: hasMore,

0 commit comments

Comments
 (0)