serial tests

Author: gsabran

package.json

@@ -57,5 +57,9 @@
 		"ava": "^6.1.1",
 		"jest-image-snapshot": "^6.5.1",
 		"xo": "^0.56.0"
+	},
+	"ava": {
+		"serial": true,
+		"timeout": "30s"
 	}
 }

test.js

@@ -10,21 +10,43 @@ const { configureToMatchImageSnapshot } = jestImageSnapshot;
 
 const __dirname = path.dirname(fileURLToPath(import.meta.url));
 
+// Clean up any leftover mounted Fixture volumes from previous test runs
+try {
+	const volumes = fs.readdirSync('/Volumes');
+	for (const volume of volumes) {
+		if (volume.startsWith('Fixture')) {
+			spawnSync('hdiutil', ['unmount', '-force', path.join('/Volumes', volume)], { timeout: 5000 });
+		}
+	}
+} catch {
+	// Ignore cleanup errors
+}
+
 /** Validate that the icon for the DMG matches the snapshot (with a small tolerance to avoid flakiness) */
 const assertVolumeIconMatchesSnapshot = (t, dmgPath) => {
 	// Mount the DMG and extract the volume icon
 	const existingVolumes = new Set(fs.readdirSync('/Volumes'));
-	spawnSync('hdiutil', ['mount', dmgPath]);
+	const mountResult = spawnSync('hdiutil', ['mount', dmgPath], { timeout: 10000 });
+
+	if (mountResult.status !== 0) {
+		throw new Error(`Failed to mount DMG: ${mountResult.stderr?.toString()}`);
+	}
+
 	const volumes = new Set(fs.readdirSync('/Volumes'));
 	const mountLocation = [...volumes].find(x => !existingVolumes.has(x));
 	t.truthy(mountLocation);
 	const dmgIconPath = path.join('/Volumes', mountLocation, '.VolumeIcon.icns')
 	const dirPath = path.dirname(dmgPath);
 	const iconPath = path.join(dirPath, 'VolumeIcon.icns');
 	fs.copyFileSync(dmgIconPath, iconPath);
-	spawnSync('hdiutil', ['unmount', path.join('/Volumes', mountLocation)]);
+	const unmountResult = spawnSync('hdiutil', ['unmount', '-force', path.join('/Volumes', mountLocation)], { timeout: 10000 });
+
+	if (unmountResult.status !== 0) {
+		throw new Error(`Failed to unmount ${mountLocation}: ${unmountResult.stderr?.toString()}`);
+	}
+
 	const pngPath = path.join(dirPath, 'VolumeIcon.png');
-	spawnSync('sips', ['-s', 'format', 'png', iconPath, '--out', pngPath]);
+	spawnSync('sips', ['-s', 'format', 'png', iconPath, '--out', pngPath], { timeout: 10000 });
 
 	// Compare the extracted icon to the snapshot
 	const image = fs.readFileSync(pngPath);