Bug fix: false negative unused var (#120)

* Bug fix: false negative unused var

As reported in 111, if a variable is assigned a value with a combined assignment operator, it would not be reported as unused.

Includes unit tests.

Fixes 111

* PHPStan config: don't report unmatched errors

Now the `PHP_CodeSniffer\Util\Tokens` file is imported, the `Constant T_\w+ not found` errors should no longer be thrown.

However, it depends on the order in which the files are analysed as that file is not (yet) `use`d in all files using the `T_` constants.

If I remove the `ignoreErrors`, [the build fails](https://circleci.com/gh/sirbrillig/phpcs-variable-analysis/281) on those errors for the `VariableAnalysisSniff` file, while if I leave the exclusion in, [the build fails](https://circleci.com/gh/sirbrillig/phpcs-variable-analysis/283) on a "Ignored error not matched".

So, for now, I'm leaving the ignore pattern in place and turning `reportUnmatchedIgnoredErrors` off to allow the build to pass.

Author: jrfnl

VariableAnalysis/Lib/Helpers.php

@@ -3,6 +3,7 @@
 namespace VariableAnalysis\Lib;
 
 use PHP_CodeSniffer\Files\File;
+use PHP_CodeSniffer\Util\Tokens;
 
 class Helpers {
   /**
@@ -256,7 +257,11 @@ public static function getNextAssignPointer(File $phpcsFile, $stackPtr) {
 
     // Is the next non-whitespace an assignment?
     $nextPtr = $phpcsFile->findNext(T_WHITESPACE, $stackPtr + 1, null, true, null, true);
-    if (is_int($nextPtr) && $tokens[$nextPtr]['code'] === T_EQUAL) {
+    if (is_int($nextPtr)
+      && isset(Tokens::$assignmentTokens[$tokens[$nextPtr]['code']])
+      // Ignore double arrow to prevent triggering on `foreach ( $array as $k => $v )`.
+      && $tokens[$nextPtr]['code'] !== T_DOUBLE_ARROW
+    ) {
       return $nextPtr;
     }
     return null;

VariableAnalysis/Tests/CodeAnalysis/VariableAnalysisTest.php

@@ -923,4 +923,17 @@ public function testThisWithinNestedClosedScope() {
     ];
     $this->assertEquals($expectedWarnings, $lines);
   }
+
+  public function testUnusedVarWithValueChange() {
+    $fixtureFile = $this->getFixture('UnusedVarWithValueChangeFixture.php');
+    $phpcsFile = $this->prepareLocalFileForSniffs($fixtureFile);
+    $phpcsFile->process();
+    $lines = $this->getWarningLineNumbersFromFile($phpcsFile);
+    $expectedWarnings = [
+            5,
+            8,
+            11,
+    ];
+    $this->assertEquals($expectedWarnings, $lines);
+  }
 }

VariableAnalysis/Tests/CodeAnalysis/fixtures/UnusedVarWithValueChangeFixture.php

@@ -0,0 +1,18 @@
+<?php
+
+// Issue #111.
+function foo() {
+    $var = 'abc';
+    $var = 'def';
+
+    $var2  = 'def';
+    $var2 .= 'ghi';
+
+    $var3  = 10;
+    $var3 += 20;
+}
+
+// Safeguard that this change doesn't influence (not) reporting on assignments to parameters passed by reference.
+function bar(&$param) {
+	$param .= 'foo';
+}

phpstan.neon.dist

@@ -1,5 +1,6 @@
 parameters:
   level: 7
+  reportUnmatchedIgnoredErrors: false
   autoload_files:
     - %currentWorkingDirectory%/vendor/squizlabs/php_codesniffer/autoload.php
   paths: