Guard against missing compact variable position

sirbrillig · sirbrillig · commit a792e232c0a6 · 2024-12-01T14:31:13.000-05:00
diff --git a/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php b/VariableAnalysis/Sniffs/CodeAnalysis/VariableAnalysisSniff.php
@@ -1887,7 +1887,8 @@ protected function processCompact(File $phpcsFile, $stackPtr)
 			if ($currScope === null) {
 				continue;
 			}
-			$this->markVariableReadAndWarnIfUndefined($phpcsFile, $variable->name, $variable->firstRead, $currScope);
+			$variablePosition = $variable->firstRead ? $variable->firstRead : $stackPtr;
+			$this->markVariableReadAndWarnIfUndefined($phpcsFile, $variable->name, $variablePosition, $currScope);
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1887,7 +1887,8 @@ protected function processCompact(File $phpcsFile, $stackPtr)`
`1887`	`1887`	`if ($currScope === null) {`
`1888`	`1888`	`continue;`
`1889`	`1889`	`}`
`1890`		`- $this->markVariableReadAndWarnIfUndefined($phpcsFile, $variable->name, $variable->firstRead, $currScope);`
	`1890`	`+ $variablePosition = $variable->firstRead ? $variable->firstRead : $stackPtr;`
	`1891`	`+ $this->markVariableReadAndWarnIfUndefined($phpcsFile, $variable->name, $variablePosition, $currScope);`
`1891`	`1892`	`}`
`1892`	`1893`	`}`
`1893`	`1894`