Skip to content

Commit e1bc758

Browse files
committed
chore:fix4: add improvements documentation
1 parent a860587 commit e1bc758

4 files changed

Lines changed: 2 additions & 20 deletions

File tree

example/azure-pipelines.yml

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ trigger:
99
pr: none
1010

1111
parameters:
12-
- name: XAPIEMAIL
13-
type: string
14-
displayName: X-API-EMAIL
15-
default: user@email.com
1612
- name: XAPIKEY
1713
type: string
1814
displayName: X-API-KEY
@@ -51,7 +47,6 @@ jobs:
5147
- ${{ if ne(variables['Build.Reason'],'manual') }}:
5248
- bash: |
5349
echo "##vso[task.setvariable variable=XAPIKEY]$(echo $(XAPIKEY_EXAMPLES))"
54-
echo "##vso[task.setvariable variable=XAPIEMAIL]$(echo $(XAPIEMAIL_EXAMPLES))"
5550
echo "##vso[task.setvariable variable=BUILDINGID]$(echo $(BUILDING_ID_EXAMPLES))"
5651
echo "##vso[task.setvariable variable=DASHBOARD_URL]$(echo 'https://dashboard.situm.com')"
5752
echo "##vso[task.setvariable variable=BUILDNUMBER]$(echo $(Build.BuildNumber) | awk -F"." '{if ($2 < 10) print $1"0"$2; else print $1$2}')"
@@ -62,7 +57,6 @@ jobs:
6257
- ${{ if eq(variables['Build.Reason'],'manual') }}:
6358
- bash: |
6459
echo "##vso[task.setvariable variable=XAPIKEY]$(echo ${{parameters.XAPIKEY}})"
65-
echo "##vso[task.setvariable variable=XAPIEMAIL]$(echo ${{ parameters.XAPIEMAIL}})"
6660
echo "##vso[task.setvariable variable=BUILDINGID]$(echo ${{ parameters.BUILDINGID}})"
6761
echo "##vso[task.setvariable variable=FLOORID]$(echo ${{ parameters.FLOORID}})"
6862
echo "##vso[task.setvariable variable=DASHBOARD_URL]$(echo ${{ parameters.DASHBOARD_URL }})"
@@ -74,7 +68,6 @@ jobs:
7468
- template: azure/common-steps.yaml
7569
parameters:
7670
XAPIKEY: $(XAPIKEY)
77-
XAPIEMAIL: $(XAPIEMAIL)
7871
BUILDINGID: $(BUILDINGID)
7972
FLOORID: $(FLOORID)
8073
DASHBOARD_URL: $(DASHBOARD_URL)
@@ -85,7 +78,6 @@ jobs:
8578
DASHBOARD_URL: $(DASHBOARD_URL)
8679
system: $(ubuntuVersion)
8780
BUILDINGID: $(BUILDINGID)
88-
XAPIEMAIL: $(XAPIEMAIL)
8981
BUILDNUMBER: $(BUILDNUMBER)
9082
- ${{ if ne(variables['Build.Reason'],'manual') }}:
9183
- template: azure-templates/teams-notifier.yml@sys_kubernetes_templates
@@ -107,7 +99,6 @@ jobs:
10799
- ${{ if ne(variables['Build.Reason'],'manual') }}:
108100
- bash: |
109101
echo "##vso[task.setvariable variable=XAPIKEY]$(echo $(XAPIKEY_EXAMPLES))"
110-
echo "##vso[task.setvariable variable=XAPIEMAIL]$(echo $(XAPIEMAIL_EXAMPLES))"
111102
echo "##vso[task.setvariable variable=BUILDINGID]$(echo $(BUILDING_ID_EXAMPLES))"
112103
echo "##vso[task.setvariable variable=DASHBOARD_URL]$(echo 'https://dashboard.situm.com')"
113104
echo "##vso[task.setvariable variable=BUILDNUMBER]$(echo $(Build.BuildNumber) | awk -F"." '{if ($2 < 10) print $1"0"$2; else print $1$2}')"
@@ -118,7 +109,6 @@ jobs:
118109
- ${{ if eq(variables['Build.Reason'],'manual') }}:
119110
- bash: |
120111
echo "##vso[task.setvariable variable=XAPIKEY]$(echo ${{parameters.XAPIKEY}})"
121-
echo "##vso[task.setvariable variable=XAPIEMAIL]$(echo ${{ parameters.XAPIEMAIL}})"
122112
echo "##vso[task.setvariable variable=BUILDINGID]$(echo ${{ parameters.BUILDINGID}})"
123113
echo "##vso[task.setvariable variable=FLOORID]$(echo ${{ parameters.FLOORID}})"
124114
echo "##vso[task.setvariable variable=DASHBOARD_URL]$(echo ${{ parameters.DASHBOARD_URL }})"
@@ -137,7 +127,6 @@ jobs:
137127
- template: azure/common-steps.yaml
138128
parameters:
139129
XAPIKEY: $(XAPIKEY)
140-
XAPIEMAIL: $(XAPIEMAIL)
141130
BUILDINGID: $(BUILDINGID)
142131
FLOORID: $(FLOORID)
143132
DASHBOARD_URL: $(DASHBOARD_URL)
@@ -148,7 +137,6 @@ jobs:
148137
parameters:
149138
DASHBOARD_URL: $(DASHBOARD_URL)
150139
system: $(macOSVersion)
151-
XAPIEMAIL: $(XAPIEMAIL)
152140
BUILDINGID: $(BUILDINGID)
153141
BUILDNUMBER: $(BUILDNUMBER)
154142

example/azure/build-examples.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ parameters:
33
type: string
44
- name: DASHBOARD_URL
55
type: string
6-
- name: XAPIEMAIL
7-
type: string
86
- name: BUILDINGID
97
type: string
108
- name: BUILDNUMBER
@@ -54,7 +52,7 @@ steps:
5452
gem install fastlane
5553
5654
dashboard=$(echo ${{ parameters.DASHBOARD_URL }} | awk -F"/" '{print $3}')
57-
export WHATS_NEW="Plugin version: $(pluginVersion), USER: ${{parameters.XAPIEMAIL}}, BUILDINGID: ${{ parameters.BUILDINGID }}, DASHBOARD_URL: $dashboard"
55+
export WHATS_NEW="Plugin version: $(pluginVersion), BUILDINGID: ${{ parameters.BUILDINGID }}, DASHBOARD_URL: $dashboard"
5856
export BUILDNUMBER=${{ parameters.BUILDNUMBER }}
5957
echo -e "\n[+] Setting variables to deploy:"
6058
echo -e "\t[+] Set WHATS_NEW: $WHATS_NEW"

example/azure/common-steps.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
parameters:
22
- name: system
33
type: string
4-
- name: XAPIEMAIL
5-
type: string
64
- name: XAPIKEY
75
type: string
86
- name: BUILDINGID
@@ -48,14 +46,12 @@ steps:
4846
echo "##vso[task.setvariable variable=pluginVersion]$(echo $pluginVersion)"
4947
5048
echo -e "\n[+] Variables to set:"
51-
echo -e "\t[+] X-API-EMAIL: ${{ parameters.XAPIEMAIL }}"
5249
echo -e "\t[+] BUILDINGID: ${{ parameters.BUILDINGID }}"
5350
echo -e "\t[+] FLOORID: ${{ parameters.FLOORID }}"
5451
echo -e "\t[+] DASHBOARD_URL: ${{ parameters.DASHBOARD_URL }}"
5552
echo -e "\t[+] BUILDNUMBER: ${{ parameters.BUILDNUMBER }}"
5653
echo -e "\t[+] Plugin Version used: $pluginVersion"
5754
58-
echo "export const SITUM_EMAIL = '${{ parameters.XAPIEMAIL }}';" > example/src/situm.tsx
5955
echo "export const SITUM_API_KEY = '${{ parameters.XAPIKEY }}';" >> example/src/situm.tsx
6056
echo "export const BUILDING_IDENTIFIER = '${{ parameters.BUILDINGID }}';" >> example/src/situm.tsx
6157
echo "export const SITUM_DASHBOARD_URL = '${{ parameters.DASHBOARD_URL }}';" >> example/src/situm.tsx

example/src/situm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const REMOTE_IDENTIFIER = '';
1212
export const LANGUAGE = '';
1313

1414
// A String parameter that allows you to specify which domain will be displayed inside our webview.
15-
export const SITUM_DASHBOARD_URL = 'https://dashboard.situm.com';
15+
export const API_DOMAIN = 'https://dashboard.situm.com';
1616

1717
// Supporting documentation
1818
`

0 commit comments

Comments
 (0)