-
-
Notifications
You must be signed in to change notification settings - Fork 411
Description
I found that module github.com/skydive-project/skydive/graffiti is a submodule of skydive.
However, it seems that submodule github.com/skydive-project/skydive/graffiti is not tagged. According to Go Modules standard , submodule should be tagged like relative-path-to-root/vX.X.X.
At present, when trying to import the package, downstream project would have to depend on pseudo-version of it and cannot get a valid tag version.
require github.com/skydive-project/skydive/graffiti v0.0.0-20240717134610-a4452f214754
Would you consider tagging the submodule according to Go standard, for example, releasing a tag `graffiti/v0.28.0``, so that we can use tag version to import this module in go.mod?
Moreover, when trying to import graffit and skydive together, ambiguous import will arise due two multiple modules containing the same package. You should make the newly-added module (graffti) depend on the module it was “carved out” from (skydive), at a version after which it was carved out (v0.27.0), as said in Go Modules rule
go: downloading github.com/skydive-project/skydive v0.26.0
go: example.com/m imports
github.com/skydive-project/skydive/graffiti/cmd: ambiguous import: found package github.com/skydive-project/skydive/graffiti/cmd in multiple modules:
github.com/skydive-project/skydive v0.26.0
github.com/skydive-project/skydive/graffiti v0.0.0-20240717134610-a4452f214754