Skip to content

fix #194 Static widget is a string only#195

Merged
robnagler merged 3 commits into
mainfrom
194-static-text
Mar 5, 2026
Merged

fix #194 Static widget is a string only#195
robnagler merged 3 commits into
mainfrom
194-static-text

Conversation

@moellep
Copy link
Copy Markdown
Collaborator

@moellep moellep commented Feb 18, 2026

No description provided.

@moellep moellep requested a review from robnagler February 18, 2026 23:16
Copy link
Copy Markdown
Collaborator

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the problem is that a "static" widget is a meaningless name. Fields are writable or not (readonly) by the UI. This translates to the readonly HTML attribute but this doesn't need to be the way the entity is rendered. an integer can be a readonly output from the sliclet so it has a type (integer) and should be rendered like an integer in the ui.

@moellep
Copy link
Copy Markdown
Collaborator Author

moellep commented Mar 5, 2026

I'ved updated this PR so widget: static is removed and writable: false controls how the field is rendered.

@moellep moellep requested a review from robnagler March 5, 2026 18:03
Copy link
Copy Markdown
Collaborator

@robnagler robnagler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robnagler robnagler merged commit 33bfcd9 into main Mar 5, 2026
1 check passed
@robnagler robnagler deleted the 194-static-text branch March 5, 2026 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants