Handle network errors better

[oliverjam]

react-dynamic-data-workshop/solution/src/utils/data_helpers.js

Lines 4 to 18 in fd8edc8

	const checkResponse = response => {
	if (response.status !== 200) {
	console.log(`Error with the request! ${response.status}`);
	return;
	}
	return response.json();
	};
	export const getData = url => {
	return fetch(`${url}?access_token=${accessToken}`)
	.then(checkResponse)
	.catch(err => {
	throw new Error(`fetch getUserData failed ${err}`);
	});
	};

The fetch util currently swallows non-200 responses silently (returning undefined) and catches then rethrows fetch errors. I think it would be a better example if we changed it to something like this:

const checkResponse = (res) => {
  if (!res.ok) throw new Error(`Network error: ${response.status}`);
  return res.json();
}

export const getData = url => { 
  return fetch(`${url}?access_token=${accessToken}`) 
    .then(checkResponse)
 }; 

[oliverjam]

I forgot to update the solution (I only changed the readme) which meant a bunch of people ended up using the old version in their projects. Reminder to myself to update the solution too at some point