Skip to content

Commit 9cec3a8

Browse files
maciejmakowski2003Maciej Makowski
andauthored
Refactor/rename onended to on ended (#548)
* refactor: renamed onended event to onEnded following camelCase convention * ci: yarn format --------- Co-authored-by: Maciej Makowski <maciej.makowski2608@gmail.com>
1 parent 8461d0b commit 9cec3a8

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

packages/react-native-audio-api/common/cpp/audioapi/HostObjects/AudioScheduledSourceNodeHostObject.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ class AudioScheduledSourceNodeHostObject : public AudioNodeHostObject {
1515
const std::shared_ptr<AudioScheduledSourceNode> &node)
1616
: AudioNodeHostObject(node) {
1717
addSetters(
18-
JSI_EXPORT_PROPERTY_SETTER(AudioScheduledSourceNodeHostObject, onended));
18+
JSI_EXPORT_PROPERTY_SETTER(AudioScheduledSourceNodeHostObject, onEnded));
1919
addFunctions(
2020
JSI_EXPORT_FUNCTION(AudioScheduledSourceNodeHostObject, start),
2121
JSI_EXPORT_FUNCTION(AudioScheduledSourceNodeHostObject, stop));
2222
}
2323

24-
JSI_PROPERTY_SETTER(onended) {
24+
JSI_PROPERTY_SETTER(onEnded) {
2525
auto audioScheduleSourceNode =
2626
std::static_pointer_cast<AudioScheduledSourceNode>(node_);
2727

packages/react-native-audio-api/src/core/AudioScheduledSourceNode.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,13 @@ export default class AudioScheduledSourceNode extends AudioNode {
4444
(this.node as IAudioScheduledSourceNode).stop(when);
4545
}
4646

47-
public get onended(): ((event: EventEmptyType) => void) | undefined {
47+
public get onEnded(): ((event: EventEmptyType) => void) | undefined {
4848
return this.onEndedCallback;
4949
}
5050

51-
public set onended(callback: ((event: EventEmptyType) => void) | null) {
51+
public set onEnded(callback: ((event: EventEmptyType) => void) | null) {
5252
if (!callback) {
53-
(this.node as IAudioScheduledSourceNode).onended = '0';
53+
(this.node as IAudioScheduledSourceNode).onEnded = '0';
5454
this.onendedSubscription?.remove();
5555
this.onendedSubscription = undefined;
5656
this.onEndedCallback = undefined;
@@ -63,7 +63,7 @@ export default class AudioScheduledSourceNode extends AudioNode {
6363
callback
6464
);
6565

66-
(this.node as IAudioScheduledSourceNode).onended =
66+
(this.node as IAudioScheduledSourceNode).onEnded =
6767
this.onendedSubscription.subscriptionId;
6868
}
6969
}

packages/react-native-audio-api/src/interfaces.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ export interface IAudioScheduledSourceNode extends IAudioNode {
9696
stop: (when: number) => void;
9797

9898
// passing subscriptionId(uint_64 in cpp, string in js) to the cpp
99-
onended: string;
99+
onEnded: string;
100100
}
101101

102102
export interface IAudioBufferBaseSourceNode extends IAudioScheduledSourceNode {

0 commit comments

Comments
 (0)