From f9bc77ea035e66746665988c361737da9ea03f3a Mon Sep 17 00:00:00 2001 From: Lukasz Lancucki Date: Fri, 27 Mar 2026 17:31:53 +0000 Subject: [PATCH] test(helpdesk): unskip some chat participants e2e tests --- .../helpdesk/chats/participants/test_async_participants.py | 5 +---- .../helpdesk/chats/participants/test_sync_participants.py | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/e2e/helpdesk/chats/participants/test_async_participants.py b/tests/e2e/helpdesk/chats/participants/test_async_participants.py index 4b086f08..795cd5a9 100644 --- a/tests/e2e/helpdesk/chats/participants/test_async_participants.py +++ b/tests/e2e/helpdesk/chats/participants/test_async_participants.py @@ -8,7 +8,6 @@ pytestmark = [pytest.mark.flaky] -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") async def test_list_chat_participants(async_chat_participants_service): result = await async_chat_participants_service.fetch_page(limit=1) @@ -42,7 +41,6 @@ async def test_delete_chat_participant( await async_chat_participants_service.delete(result.id) -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") async def test_update_chat_participant_not_found( async_chat_participants_service, invalid_chat_participant_id ): @@ -54,10 +52,9 @@ async def test_update_chat_participant_not_found( assert error.value.status_code == HTTPStatus.NOT_FOUND -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") async def test_delete_chat_participant_not_found( async_chat_participants_service, invalid_chat_participant_id ): with pytest.raises(MPTAPIError) as error: await async_chat_participants_service.delete(invalid_chat_participant_id) - assert error.value.status_code == HTTPStatus.NOT_FOUND + assert error.value.status_code == HTTPStatus.BAD_REQUEST # TODO: verify 400 is OK instead 404 diff --git a/tests/e2e/helpdesk/chats/participants/test_sync_participants.py b/tests/e2e/helpdesk/chats/participants/test_sync_participants.py index 7d45e9a0..8894dbd3 100644 --- a/tests/e2e/helpdesk/chats/participants/test_sync_participants.py +++ b/tests/e2e/helpdesk/chats/participants/test_sync_participants.py @@ -8,7 +8,6 @@ pytestmark = [pytest.mark.flaky] -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") def test_list_chat_participants(chat_participants_service): result = chat_participants_service.fetch_page(limit=1) @@ -35,7 +34,6 @@ def test_delete_chat_participant(chat_participants_service, created_chat_partici chat_participants_service.delete(result.id) -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") def test_update_chat_participant_not_found(chat_participants_service, invalid_chat_participant_id): with pytest.raises(MPTAPIError) as error: chat_participants_service.update(invalid_chat_participant_id, {"status": "Active"}) @@ -43,9 +41,8 @@ def test_update_chat_participant_not_found(chat_participants_service, invalid_ch assert error.value.status_code == HTTPStatus.NOT_FOUND -@pytest.mark.skip(reason="Unskip after MPT-19124 completed") def test_delete_chat_participant_not_found(chat_participants_service, invalid_chat_participant_id): with pytest.raises(MPTAPIError) as error: chat_participants_service.delete(invalid_chat_participant_id) - assert error.value.status_code == HTTPStatus.NOT_FOUND + assert error.value.status_code == HTTPStatus.BAD_REQUEST # TODO: verify 400 is OK instead 404