Spider - tweak life cycle hooks

The life cycle hooks as they stand don't particularly sit well with the architecture, but do currently perform an important functionality and work. So, rather than making radical changes, just add a bit more safety, checking and logging. This stuff will likely just be removed after a sufficient amount of movement of functionality over to tau.

Author: samaaron

app/server/ruby/lib/sonicpi/lifecyclehooks.rb

@@ -11,9 +11,13 @@
 # notice is included.
 #++
 
+require_relative "util"
+
 module SonicPi
   class LifeCycleHooks
 
+    include Util
+
     # Life cycle hooks for jobs
 
     def initialize
@@ -23,65 +27,91 @@ def initialize
       @exited_blocks = []
       @all_completed_blocks = []
       @mut = Mutex.new
+      @started = false
+    end
+
+    def ensure_not_started!
+      if @started
+        raise StandardError "Cannot modify life cycle hooks once started"
+      end
     end
 
     def on_init(&blck)
       @mut.synchronize do
+        ensure_not_started!
         @started_blocks << blck
       end
     end
 
     def on_completed(&blck)
       @mut.synchronize do
+        ensure_not_started!
         @completed_blocks << blck
       end
     end
 
     def on_killed(&blck)
       @mut.synchronize do
+        ensure_not_started!
         @killed_blocks << blck
       end
     end
 
     def on_exit(&blck)
       @mut.synchronize do
+        ensure_not_started!
         @exited_blocks << blck
       end
     end
 
     def on_all_completed(&blck)
       @mut.synchronize do
+        ensure_not_started!
         @all_completed_blocks << blck
       end
     end
 
     def init(job_id, arg={})
-      @started_blocks.each do |b|
-        b.call(job_id, arg)
+      log "Lifecycle Hooks Init"
+      @mut.synchronize do
+        @started = true
+        @started_blocks.each do |b|
+          b.call(job_id, arg)
+        end
       end
     end
 
     def completed(job_id, arg={})
-      @completed_blocks.each do |b|
-        b.call(job_id, arg)
+      log "Lifecycle Hooks Completed"
+      @mut.synchronize do
+        @completed_blocks.each do |b|
+          b.call(job_id, arg)
+        end
       end
     end
 
     def all_completed(silent=false)
-      @all_completed_blocks.each do |b|
-        b.call(silent)
+      log "Lifecycle Hooks All Completed"
+      @mut.synchronize do
+        @all_completed_blocks.each do |b|
+          b.call(silent)
+        end
       end
     end
 
     def killed(job_id, arg={})
-      @killed_blocks.each do |b|
-        b.call(job_id, arg)
+      @mut.synchronize do
+        @killed_blocks.each do |b|
+          b.call(job_id, arg)
+        end
       end
     end
 
     def exit(job_id, arg={})
-      @exited_blocks.each do |b|
-        b.call(job_id, arg)
+      @mut.synchronize do
+        @exited_blocks.each do |b|
+          b.call(job_id, arg)
+        end
       end
     end
   end