Skip to content

Commit 1589fcb

Browse files
committed
ux: diff/merge args should hide when using git configuration (#1971)
Signed-off-by: leo <longshuang@msn.cn>
1 parent 1a5a9ae commit 1589fcb

File tree

1 file changed

+22
-17
lines changed

1 file changed

+22
-17
lines changed

src/Views/Preferences.axaml

Lines changed: 22 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -501,8 +501,7 @@
501501
Height="32"
502502
Margin="0,0,16,0"
503503
IsVisible="{OnPlatform True, macOS=False}">
504-
<TextBlock Grid.Row="1" Grid.Column="0"
505-
Text="{DynamicResource Text.Preferences.Shell.Path}"
504+
<TextBlock Text="{DynamicResource Text.Preferences.Shell.Path}"
506505
HorizontalAlignment="Right" />
507506
</Border>
508507
<TextBox Grid.Row="1" Grid.Column="1"
@@ -521,8 +520,7 @@
521520
Height="32"
522521
Margin="0,0,16,0"
523522
IsVisible="{OnPlatform True, macOS=False}">
524-
<TextBlock Grid.Row="1" Grid.Column="0"
525-
Text="{DynamicResource Text.Preferences.Shell.Args}"
523+
<TextBlock Text="{DynamicResource Text.Preferences.Shell.Args}"
526524
HorizontalAlignment="Right" />
527525
</Border>
528526
<TextBox Grid.Row="2" Grid.Column="1"
@@ -537,7 +535,7 @@
537535
<TextBlock Classes="bold" Margin="4,0,0,0" Text="{DynamicResource Text.Preferences.DiffMerge}"/>
538536
</StackPanel>
539537
<Rectangle Margin="0,8" Fill="{DynamicResource Brush.Border2}" Height=".6" HorizontalAlignment="Stretch"/>
540-
<Grid Margin="8,0,0,8" RowDefinitions="32,Auto,32,32">
538+
<Grid Margin="8,0,0,8" RowDefinitions="32,Auto,Auto,Auto">
541539
<Grid.ColumnDefinitions>
542540
<ColumnDefinition Width="Auto" SharedSizeGroup="IntegrationLabel"/>
543541
<ColumnDefinition Width="*"/>
@@ -570,8 +568,7 @@
570568
Height="32"
571569
Margin="0,0,16,0"
572570
IsVisible="{Binding ExternalMergeToolType, Converter={x:Static c:IntConverters.IsGreaterThanZero}}">
573-
<TextBlock Grid.Row="1" Grid.Column="0"
574-
Text="{DynamicResource Text.Preferences.DiffMerge.Path}"
571+
<TextBlock Text="{DynamicResource Text.Preferences.DiffMerge.Path}"
575572
HorizontalAlignment="Right" />
576573
</Border>
577574
<TextBox Grid.Row="1" Grid.Column="1"
@@ -587,23 +584,31 @@
587584
</TextBox.InnerRightContent>
588585
</TextBox>
589586

590-
<TextBlock Grid.Row="2" Grid.Column="0"
591-
Text="{DynamicResource Text.Preferences.DiffMerge.DiffArgs}"
592-
HorizontalAlignment="Right"
593-
Margin="0,0,16,0"/>
587+
<Border Grid.Row="2" Grid.Column="0"
588+
Height="32"
589+
Margin="0,0,16,0"
590+
IsVisible="{Binding ExternalMergeToolType, Converter={x:Static c:IntConverters.IsGreaterThanZero}}">
591+
<TextBlock Text="{DynamicResource Text.Preferences.DiffMerge.DiffArgs}"
592+
HorizontalAlignment="Right" />
593+
</Border>
594594
<TextBox Grid.Row="2" Grid.Column="1"
595595
Height="28"
596596
CornerRadius="3"
597-
Text="{Binding ExternalMergeToolDiffArgs, Mode=TwoWay}"/>
597+
Text="{Binding ExternalMergeToolDiffArgs, Mode=TwoWay}"
598+
IsVisible="{Binding ExternalMergeToolType, Converter={x:Static c:IntConverters.IsGreaterThanZero}}"/>
598599

599-
<TextBlock Grid.Row="3" Grid.Column="0"
600-
Text="{DynamicResource Text.Preferences.DiffMerge.MergeArgs}"
601-
HorizontalAlignment="Right"
602-
Margin="0,0,16,0"/>
600+
<Border Grid.Row="3" Grid.Column="0"
601+
Height="32"
602+
Margin="0,0,16,0"
603+
IsVisible="{Binding ExternalMergeToolType, Converter={x:Static c:IntConverters.IsGreaterThanZero}}">
604+
<TextBlock Text="{DynamicResource Text.Preferences.DiffMerge.MergeArgs}"
605+
HorizontalAlignment="Right" />
606+
</Border>
603607
<TextBox Grid.Row="3" Grid.Column="1"
604608
Height="28"
605609
CornerRadius="3"
606-
Text="{Binding ExternalMergeToolMergeArgs, Mode=TwoWay}"/>
610+
Text="{Binding ExternalMergeToolMergeArgs, Mode=TwoWay}"
611+
IsVisible="{Binding ExternalMergeToolType, Converter={x:Static c:IntConverters.IsGreaterThanZero}}"/>
607612
</Grid>
608613
</StackPanel>
609614
</TabItem>

0 commit comments

Comments
 (0)