Skip to content

Commit 5ba2840

Browse files
authored
docs: adjusting pure-docker release steps (#827)
1 parent 4bcdf13 commit 5ba2840

File tree

1 file changed

+31
-35
lines changed

1 file changed

+31
-35
lines changed

RELEASING.md

Lines changed: 31 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -78,17 +78,27 @@ git checkout 3.8-customer-replica
7878
# Create the new pure-docker release branch
7979
git checkout -B 3.9-customer-replica
8080

81-
# Merge the publish-3.9 branch, which will have been created by the release tool, into the pure-docker release branch. Default to taking the remote changes.
81+
# Merge the publish-3.9 branch, which will have been created by the release tool, into the pure-docker release branch. Default to taking the remote changes. Note that "theirs" is a Git term, not a placeholder.
8282
git merge publish-3.9 -X theirs
8383

8484
# Reset to previous commit so we can manually inspect ALL changes - we want to create multiple commits instead of keeping a single merge commit
8585
git reset HEAD~
8686

8787
# Show which files may have been deleted, etc.
8888
git status
89-
9089
```
9190

91+
While committing in next steps, you will run into two merge conflicts:
92+
93+
- Do not commit `deploy-caddy.sh` or changes related to it, as `deploy-apache.sh` is used here.
94+
- The `.prettierignore` should contain the following lines:
95+
96+
```
97+
.github/
98+
*.md
99+
rootfs/etc/docker/daemon.json
100+
```
101+
92102
At this point you should evaluate the `git status` output as well as all the changes in your working git directory. You need to ensure the following happens:
93103
94104
1. Files that were shown as deleted in the `git status` output get deleted in the relevant commit.
@@ -98,22 +108,10 @@ At this point you should evaluate the `git status` output as well as all the cha
98108
- Do not include `docker-compose/` changes in this commit, those are irrelevant to pure-docker users.
99109
- Double check `pure-docker/deploy-pgsql.sh` file and make sure it has the correct image sha. It should look something like `index.docker.io/sourcegraph/postgres-12.6-alpine:3.36.3@sha256:<hash>`
100110
- `git commit -m 'upgrade to v3.9.0'`
101-
102-
During this process you will run into two merge conflicts:
103-
104-
- Do not commit: `deploy-caddy.sh` or changes related to it, as `deploy-apache.sh` is used here.
105-
- The prettier ignore should look like this:
106-
107-
```
108-
.github/
109-
*.md
110-
rootfs/etc/docker/daemon.json
111-
```
112-
113-
1. Push the changes to github
114-
```shell
115-
git push --set-upstream origin 3.9-customer-replica
116-
```
111+
4. Push the changes
112+
```shell
113+
git push --set-upstream origin 3.9-customer-replica
114+
```
117115
118116
Check buildkite for the branch after pushing it, e.g. at https://github.com/sourcegraph/deploy-sourcegraph-docker/commits/3.19-customer-replica
119117
@@ -151,9 +149,19 @@ git reset HEAD~
151149

152150
# Show which files may have been deleted, etc.
153151
git status
154-
155152
```
156153

154+
While committing in next steps, you will run into two merge conflicts:
155+
156+
- Do not commit `deploy-caddy.sh` or changes related to it, as `deploy-apache.sh` is used here.
157+
- The `.prettierignore` should contain the following lines:
158+
159+
```
160+
.github/
161+
*.md
162+
rootfs/etc/docker/daemon.json
163+
```
164+
157165
At this point you should evaluate the `git status` output as well as all the changes in your working git directory. You need to ensure the following happens:
158166
159167
1. Files that were shown as deleted in the `git status` output get deleted in the relevant commit.
@@ -163,22 +171,10 @@ At this point you should evaluate the `git status` output as well as all the cha
163171
- Do not include `docker-compose/` changes in this commit, those are irrelevant to pure-docker users.
164172
- Double check `pure-docker/deploy-pgsql.sh` file and make sure it has the correct image sha. It should look something like `index.docker.io/sourcegraph/postgres-12.6-alpine:3.36.3@sha256:<hash>`
165173
- `git commit -m 'upgrade to v3.8.1'`
166-
167-
During this process you will run into two merge conflicts:
168-
169-
- Do not commit: `deploy-caddy.sh` or changes related to it, as `deploy-apache.sh` is used here.
170-
- The prettier ignore should look like this:
171-
172-
```
173-
.github/
174-
*.md
175-
rootfs/etc/docker/daemon.json
176-
```
177-
178-
1. Push the changes to github
179-
```shell
180-
git push --set-upstream origin 3.8.1-customer-replica
181-
```
174+
4. Push the changes to github
175+
```shell
176+
git push --set-upstream origin 3.8.1-customer-replica
177+
```
182178
183179
Open a Pull Request against `3.8-customer-replica` (base branch)
184180

0 commit comments

Comments
 (0)