Skip to content

Commit b5fd02c

Browse files
Move comments outside of docker run command (#821)
1 parent e23b532 commit b5fd02c

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

pure-docker/deploy-cadvisor.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ source ./replicas.sh
1313
# Also add the following volume mount for container monitoring on MacOS:
1414
# --volume='/var/run/docker.sock:/var/run/docker.sock:ro'
1515
#
16+
# You may remove the --privileged flag to run with reduced privileges.
17+
# `cadvisor` requires root privileges in order to display provisioning metrics.
18+
# These metrics provide critical information to help you scale the Sourcegraph deployment.
19+
# If you would like to bring your own infrastructure monitoring & alerting solution,
20+
# you may want to remove the `cadvisor` container completely
1621
sudo docker run --detach \
1722
--name=cadvisor \
1823
--network=sourcegraph \
@@ -24,11 +29,6 @@ sudo docker run --detach \
2429
--volume=/sys:/sys:ro \
2530
--volume=/var/lib/docker/:/var/lib/docker:ro \
2631
--volume=/dev/disk/:/dev/disk:ro \
27-
# You may set `privileged` to `false and `cadvisor` will run with reduced privileges.
28-
# `cadvisor` requires root privileges in order to display provisioning metrics.
29-
# These metrics provide critical information to help you scale the Sourcegraph deployment.
30-
# If you would like to bring your own infrastructure monitoring & alerting solution,
31-
# you may want to remove the `cadvisor` container completely
3232
--privileged \
3333
--device=/dev/kmsg \
3434
index.docker.io/sourcegraph/cadvisor:3.36.3@sha256:249c573262967979889a186344ba5cc4e8e9186ec4f26c759ce9f8527560da69 \

0 commit comments

Comments
 (0)