chore: update linting

Author: felixfbecker

package.json

@@ -58,8 +58,8 @@
   },
   "devDependencies": {
     "@sourcegraph/prettierrc": "^2.0.0",
-    "@sourcegraph/tsconfig": "^1.0.0",
-    "@sourcegraph/tslint-config": "^9.0.2",
+    "@sourcegraph/tsconfig": "^3.0.0",
+    "@sourcegraph/tslint-config": "^11.0.1",
     "@types/chai": "4.0.6",
     "@types/chai-as-promised": "^7.1.0",
     "@types/glob": "^5.0.30",

src/packages.ts

@@ -2,7 +2,6 @@ import { EventEmitter } from 'events'
 import { Span } from 'opentracing'
 import * as path from 'path'
 import { Observable, Subscription } from 'rxjs'
-import { SelectorMethodSignature } from 'rxjs/observable/FromEventObservable'
 import * as url from 'url'
 import { Disposable } from './disposable'
 import { FileSystemUpdater } from './fs'
@@ -99,38 +98,38 @@ export class PackageManager extends EventEmitter implements Disposable {
         let rootPackageJsonLevel = Infinity
         // Find locations of package.jsons _not_ inside node_modules
         this.subscriptions.add(
-            Observable.fromEvent(this.inMemoryFileSystem, 'add', Array.of as SelectorMethodSignature<
-                [string, string]
-            >).subscribe(([uri, content]) => {
-                const parts = url.parse(uri)
-                if (
-                    !parts.pathname ||
-                    !parts.pathname.endsWith('/package.json') ||
-                    parts.pathname.includes('/node_modules/')
-                ) {
-                    return
-                }
-                let parsed: PackageJson | undefined
-                if (content) {
-                    try {
-                        parsed = JSON.parse(content)
-                    } catch (err) {
-                        logger.error(`Error parsing package.json:`, err)
+            Observable.fromEvent<[string, string]>(this.inMemoryFileSystem, 'add', (k, v) => [k, v]).subscribe(
+                ([uri, content]) => {
+                    const parts = url.parse(uri)
+                    if (
+                        !parts.pathname ||
+                        !parts.pathname.endsWith('/package.json') ||
+                        parts.pathname.includes('/node_modules/')
+                    ) {
+                        return
+                    }
+                    let parsed: PackageJson | undefined
+                    if (content) {
+                        try {
+                            parsed = JSON.parse(content)
+                        } catch (err) {
+                            logger.error(`Error parsing package.json:`, err)
+                        }
+                    }
+                    // Don't override existing content with undefined
+                    if (parsed || !this.packages.get(uri)) {
+                        this.packages.set(uri, parsed)
+                        this.logger.log(`Found package ${uri}`)
+                        this.emit('parsed', uri, parsed)
+                    }
+                    // If the current root package.json is further nested than this one, replace it
+                    const level = parts.pathname.split('/').length
+                    if (level < rootPackageJsonLevel) {
+                        this.rootPackageJsonUri = uri
+                        rootPackageJsonLevel = level
                     }
                 }
-                // Don't override existing content with undefined
-                if (parsed || !this.packages.get(uri)) {
-                    this.packages.set(uri, parsed)
-                    this.logger.log(`Found package ${uri}`)
-                    this.emit('parsed', uri, parsed)
-                }
-                // If the current root package.json is further nested than this one, replace it
-                const level = parts.pathname.split('/').length
-                if (level < rootPackageJsonLevel) {
-                    this.rootPackageJsonUri = uri
-                    rootPackageJsonLevel = level
-                }
-            })
+            )
         )
     }
 

src/project-manager.ts

@@ -3,7 +3,6 @@ import { noop } from 'lodash'
 import { Span } from 'opentracing'
 import * as path from 'path'
 import { Observable, Subscription } from 'rxjs'
-import { SelectorMethodSignature } from 'rxjs/observable/FromEventObservable'
 import * as ts from 'typescript'
 import { Disposable } from './disposable'
 import { FileSystemUpdater } from './fs'
@@ -626,7 +625,7 @@ export class ProjectManager implements Disposable {
 
         // Whenever a file with content is added to the InMemoryFileSystem, check if it's a tsconfig.json and add a new ProjectConfiguration
         this.subscriptions.add(
-            Observable.fromEvent(inMemoryFileSystem, 'add', Array.of as SelectorMethodSignature<[string, string]>)
+            Observable.fromEvent<[string, string]>(inMemoryFileSystem, 'add', (k, v) => [k, v])
                 .filter(
                     ([uri, content]) => !!content && /\/[tj]sconfig\.json/.test(uri) && !uri.includes('/node_modules/')
                 )

tsconfig.json

@@ -5,19 +5,16 @@
     "target": "es2016",
     "module": "commonjs",
     "moduleResolution": "node",
-    "lib": [
-      "es2016",
-      "dom"
-    ],
+    "lib": ["es2016", "dom"],
     "sourceMap": true,
     "declaration": true,
+    "strictFunctionTypes": false,
+    "strictPropertyInitialization": false,
     "plugins": [
       {
         "name": "tslint-language-service"
       }
     ]
   },
-  "include": [
-    "src/**/*.ts"
-  ]
+  "include": ["src/**/*.ts"]
 }