Update register-action

Author: marekweb

src/register-action.ts

@@ -4,17 +4,19 @@ import { evaluateAndCreateCampaignSpec } from '@sourcegraph/campaigns-client'
 import slugify from 'slugify'
 import { getCurrentUser } from './util'
 
-// TODO(sqs) SECURITY(sqs): sanitize for real
+// TODO: sanitize this for real, it gets used in the description of the campaign
 const escapedMarkdownCode = (text: string): string => '`' + text.replace(/`/g, '\\`') + '`'
 
-// TODO: make this file filter configurable.
-// The filter is applied on all files of each matching repo (confirm - is that correct?)
+// TODO: instead of using fileFilter, use the search results as the list of matching files
 const fileFilter = (path: string): boolean => path.endsWith('.yaml') || path.endsWith('.yml') || path.endsWith('.md')
 
 export const registerFindReplaceAction = (): Subscription => {
     const subscription = new Subscription()
     subscription.add(
-        sourcegraph.commands.registerCommand('start-find-replace', async () => {
+        sourcegraph.commands.registerCommand('start-find-replace', async (searchQuery: string) => {
+            // TODO: in the future, use the search query to get the list of matching files.
+            console.log('context.searchQuery', searchQuery)
+
             // To create campaigns, a namespace is used, which can be the current user's username.
             const currentUser = await getCurrentUser()
             const namespaceName = currentUser?.username
@@ -26,9 +28,11 @@ export const registerFindReplaceAction = (): Subscription => {
             if (!match) {
                 return
             }
+
             const replacement = await sourcegraph.app.activeWindow!.showInputBox({
                 prompt: 'Replace with:',
             })
+            // Empty string is a valid replacement, so compare directly with undefined.
             if (replacement === undefined) {
                 return
             }
@@ -55,11 +59,6 @@ export const registerFindReplaceAction = (): Subscription => {
                                     if (!text.includes(match)) {
                                         return null
                                     }
-                                    try {
-                                        console.log('editFile running on', path)
-                                    } catch (error) {
-                                        console.error('Caught', error)
-                                    }
 
                                     percentage += (100 - percentage) / 100
                                     reporter.next({ message: `Computing changes in ${path}`, percentage })
@@ -81,13 +80,10 @@ export const registerFindReplaceAction = (): Subscription => {
                         },
                     })
             )
-            await sourcegraph.app.activeWindow!.showNotification(
-                `[**Find-replace changes**](${applyURL}) are ready to preview and apply.<br/><br/><small>${diffStat.added} additions, ${diffStat.changed} changes, ${diffStat.deleted} deletions</small>`,
+            sourcegraph.app.activeWindow!.showNotification(
+                `[**Find-replace changes**](${applyURL}) are ready to preview and apply.<br/><br/><small>${diffStat.changed} changes made.</small>`,
                 sourcegraph.NotificationType.Success
             )
-
-            // const relativeURL = new URL(applyURL)
-            // await sourcegraph.commands.executeCommand('open', `${relativeURL.pathname}${relativeURL.search}`)
         })
     )
     return subscription