Add button to submit feedback (#70)

Author: chrismwendt

dev

@@ -8,5 +8,5 @@ env FORCE_COLOR=0 \
     --names serve,build \
     --prefix name \
     --kill-others \
-    'yarn run serve | cat' \
+    'yarn run serve --no-cache | cat' \
     'yarn run watch:typecheck'

package.json

@@ -46,9 +46,27 @@
           "label": "References: Search mode",
           "description": "Results come from text search and heuristics. To use a language server for precise results, click to go to the README and follow the deployment instructions."
         }
+      },
+      {
+        "id": "feedback",
+        "command": "open",
+        "title": "Submit code intel feedback",
+        "commandArguments": [
+          "${get(context, `codeIntel.feedbackLink`)}"
+        ],
+        "actionItem": {
+          "description": "Submit code intel feedback",
+          "iconURL": "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0Ij48cGF0aCBkPSJNMCAwaDI0djI0SDB6IiBmaWxsPSJub25lIi8+PHBhdGggZD0iTTExLjk5IDJDNi40NyAyIDIgNi40OCAyIDEyczQuNDcgMTAgOS45OSAxMEMxNy41MiAyMiAyMiAxNy41MiAyMiAxMlMxNy41MiAyIDExLjk5IDJ6TTEyIDIwYy00LjQyIDAtOC0zLjU4LTgtOHMzLjU4LTggOC04IDggMy41OCA4IDgtMy41OCA4LTggOHptMy41LTljLjgzIDAgMS41LS42NyAxLjUtMS41UzE2LjMzIDggMTUuNSA4IDE0IDguNjcgMTQgOS41cy42NyAxLjUgMS41IDEuNXptLTcgMGMuODMgMCAxLjUtLjY3IDEuNS0xLjVTOS4zMyA4IDguNSA4IDcgOC42NyA3IDkuNSA3LjY3IDExIDguNSAxMXptMy41IDYuNWMyLjMzIDAgNC4zMS0xLjQ2IDUuMTEtMy41SDYuODljLjggMi4wNCAyLjc4IDMuNSA1LjExIDMuNXoiLz48L3N2Zz4="
+        }
       }
     ],
     "menus": {
+      "editor/title": [
+        {
+          "action": "feedback",
+          "when": "showFeedback"
+        }
+      ],
       "panel/toolbar": [
         {
           "action": "externalReferences.toggle",
@@ -121,7 +139,7 @@
     "typescript": "^3.1.6"
   },
   "dependencies": {
-    "@sourcegraph/basic-code-intel": "6.0.15",
+    "@sourcegraph/basic-code-intel": "6.0.16",
     "@sourcegraph/vscode-ws-jsonrpc": "0.0.3-fork",
     "prettier": "^1.16.4",
     "rxjs": "^6.3.3",

src/lang-go.ts

@@ -1,6 +1,6 @@
 import '@babel/polyfill'
 
-import { activateBasicCodeIntel } from '@sourcegraph/basic-code-intel'
+import { activateBasicCodeIntel, registerFeedbackButton } from '@sourcegraph/basic-code-intel'
 import * as wsrpc from '@sourcegraph/vscode-ws-jsonrpc'
 import { ajax } from 'rxjs/ajax'
 import * as sourcegraph from 'sourcegraph'
@@ -741,6 +741,8 @@ export function activate(ctx: sourcegraph.ExtensionContext = DUMMY_CTX): void {
     async function afterActivate(): Promise<void> {
         const address = sourcegraph.configuration.get<Settings>().get('go.serverUrl')
         if (address) {
+            ctx.subscriptions.add(registerFeedbackButton({ languageID: 'go', sourcegraph, isPrecise: true }))
+
             await activateUsingWebSockets(ctx)
         } else {
             activateBasicCodeIntel({

yarn.lock

@@ -700,10 +700,10 @@
   resolved "https://registry.yarnpkg.com/@sindresorhus/is/-/is-0.7.0.tgz#9a06f4f137ee84d7df0460c1fdb1135ffa6c50fd"
   integrity sha512-ONhaKPIufzzrlNbqtWFFd+jlnemX6lJAgq9ZeiZtS7I1PIf/la7CW4m83rTXRnVnsMbW2k56pGYu7AUFJD9Pow==
 
-"@sourcegraph/basic-code-intel@6.0.15":
-  version "6.0.15"
-  resolved "https://registry.yarnpkg.com/@sourcegraph/basic-code-intel/-/basic-code-intel-6.0.15.tgz#b7c0baa894d89244fc5155a08839543cdbcca4ea"
-  integrity sha512-oMNbyAar7Sy4gnX5hLXQZhmLFy19zFtKndkJ4BlLCvRsmuJozMgWT32sUnhpDrco32NJQf6Irgl7a7PFX1Gb5w==
+"@sourcegraph/basic-code-intel@6.0.16":
+  version "6.0.16"
+  resolved "https://registry.yarnpkg.com/@sourcegraph/basic-code-intel/-/basic-code-intel-6.0.16.tgz#ebbb52e6230cee61f237b00cc70127a67bdb84bc"
+  integrity sha512-tdntEWesRTLF+jYHT/1HEHmKh64bNTHbKtYYfIBDOegU7PJh4K2ZxmQnB+bJMlrj2FHRqCz7Lg/vLL5fYcVOGw==
   dependencies:
     lodash "^4.17.11"
     rxjs "^6.3.3"