show "Copied" indicator when copying an access token (#63936)

sqs · web-flow · commit 3c8b8e9e25f8 · 2024-07-19T01:21:07.000-07:00
For some reason, the indication that the text was copied was removed for
secrets. The indication does not show the secret value itself, so I
don't see why that change was made. It is helpful to the user to give
them feedback that the secret was in fact copied.


## Test plan

Click the copy button after creating an access token
diff --git a/client/web/src/components/CopyableText.tsx b/client/web/src/components/CopyableText.tsx
@@ -77,7 +77,7 @@ export class CopyableText extends React.PureComponent<Props, State> {
                                 aria-label="Copy"
                             >
                                 <Icon aria-hidden={true} svgPath={mdiContentCopy} />{' '}
-                                {this.props.secret ? '' : this.state.copied ? 'Copied' : 'Copy'}
+                                {this.state.copied ? 'Copied' : 'Copy'}
                             </Button>
                         </div>
                         {this.props.secret && (

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ export class CopyableText extends React.PureComponent<Props, State> {`
`77`	`77`	`aria-label="Copy"`
`78`	`78`	`>`
`79`	`79`	`<Icon aria-hidden={true} svgPath={mdiContentCopy} />{' '}`
`80`		`- {this.props.secret ? '' : this.state.copied ? 'Copied' : 'Copy'}`
	`80`	`+ {this.state.copied ? 'Copied' : 'Copy'}`
`81`	`81`	`</Button>`
`82`	`82`	`</div>`
`83`	`83`	`{this.props.secret && (`