From 3f7e986bda25db329202d1ff777be885c06ea0dd Mon Sep 17 00:00:00 2001 From: Juan Cruz Viotti Date: Fri, 6 Mar 2026 09:13:17 -0400 Subject: [PATCH] Remove incorrect external tooltips for linter rules See: https://github.com/sourcemeta/studio/issues/173 Fixes: https://github.com/sourcemeta/studio/issues/174 Signed-off-by: Juan Cruz Viotti --- test/vscode/extension.test.js | 13 ++++++++++++- vscode/index.js | 8 ++------ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/test/vscode/extension.test.js b/test/vscode/extension.test.js index 75dbc02..6416d3d 100644 --- a/test/vscode/extension.test.js +++ b/test/vscode/extension.test.js @@ -167,11 +167,22 @@ suite('Extension Test Suite', () => { const document = await openFixture('test-schema.json'); await vscode.commands.executeCommand('sourcemeta-studio.openPanel'); const diagnostics = await waitForDiagnostics(document.uri, LINT_SOURCE); - const ruleIds = diagnostics.map(d => d.code.value); + const ruleIds = diagnostics.map(d => d.code); assert.ok(ruleIds.includes('top_level_description')); assert.ok(ruleIds.includes('top_level_examples')); }); + test('Should not provide a URL target for lint diagnostic codes', async function() { + this.timeout(15000); + await activateExtension(); + const document = await openFixture('test-schema.json'); + await vscode.commands.executeCommand('sourcemeta-studio.openPanel'); + const diagnostics = await waitForDiagnostics(document.uri, LINT_SOURCE); + for (const diagnostic of diagnostics) { + assert.strictEqual(typeof diagnostic.code, 'string'); + } + }); + test('Should include related information in lint diagnostics', async function() { this.timeout(15000); await activateExtension(); diff --git a/vscode/index.js b/vscode/index.js index a4352c0..1369562 100644 --- a/vscode/index.js +++ b/vscode/index.js @@ -232,12 +232,8 @@ function updateLintDiagnostics(documentUri, errors) { diagnostic.source = 'Sourcemeta Studio (Lint)'; - if (error.id) { - diagnostic.code = { - value: error.id, - target: vscode.Uri.parse(`https://github.com/Karan-Palan/json-schema-lint-rules/tree/main/docs/${error.id}.md`) - }; - } + // TODO: Provide a documentation URL target when we have per-rule docs + diagnostic.code = error.id; diagnostic.relatedInformation = buildRelatedInfo( new vscode.Location(documentUri, range), [