From 18faf8036c9762370b36d37ceb5d6682e37e04a9 Mon Sep 17 00:00:00 2001
From: Veton Shabani <68129513+vetonshabani0@users.noreply.github.com>
Date: Thu, 23 Jul 2026 20:51:47 +0200
Subject: [PATCH] Don't cache-bust the pre-built Yardline RC bundle
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The deploy stamp appends ?v=<guid> to every game's entry <script src>. That's
correct for the hand-written zero-build games, but it was breaking Yardline RC,
a pre-built Vite app. Its assets are already content-hashed (cache-busted), and
the app derives dynamic-import URLs from import.meta.url — so the ?v on the entry
rides along to lazily-loaded chunks while their preloaded copies have none. The
browser then loads a SECOND copy of shared Babylon modules, whose duplicate class
decorators throw `Cannot redefine property: onBeforeViewRenderObservable` at
scene init, aborting model loading — the garage rendered but no cars.

This is why the game worked when served straight from the vite build but broke
once it went through the deploy stamp (both on GitHub Pages and on Render).

Fix: a NO_STAMP list; yardline-rc is copied but never stamped. Verified by
running the real build and rendering the stamped _dist under a subpath on a real
GPU — the car is on the pedestal, no crash. Zero-build games still get stamped.
---
 scripts/stamp.mjs | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/scripts/stamp.mjs b/scripts/stamp.mjs
index d5326c6f..91c23177 100644
--- a/scripts/stamp.mjs
+++ b/scripts/stamp.mjs
@@ -14,12 +14,25 @@
 // so stamping only the entry <script> would leave the modules cached.
 
 import { cp, readFile, writeFile, rm, readdir } from "node:fs/promises";
-import { join, extname } from "node:path";
+import { join, extname, relative, sep } from "node:path";
 import { randomUUID } from "node:crypto";
 
 const SRC = ".";
 const OUT = "_dist";
 
+// Pre-built games whose OWN bundler already content-hashes every asset (e.g. a
+// Vite build: index-CSoa7UUc.js). They are cache-busted by those hashes, so they
+// must be copied but NEVER stamped. Appending ?v to a Vite entry is actively
+// harmful: the app derives dynamic-import URLs from import.meta.url, so the query
+// rides along and a second copy of shared modules loads under the ?v URL while
+// the preloaded copy has none. For Babylon.js that double-init throws
+// "Cannot redefine property: onBeforeViewRenderObservable" and the scene dies.
+const NO_STAMP = ["yardline-rc"];
+function isNoStamp(file) {
+  const rel = relative(OUT, file);
+  return NO_STAMP.some((d) => rel === d || rel.startsWith(d + sep));
+}
+
 // What gets copied into the deployable site. Everything the browser needs and
 // nothing else (no node_modules, scripts, CI, git, or the previous build).
 const INCLUDE = [
@@ -108,6 +121,7 @@ async function main() {
   }
 
   for await (const file of walk(OUT)) {
+    if (isNoStamp(file)) continue; // pre-built app — leave its hashed assets alone
     const ext = extname(file).toLowerCase();
     if (ext === ".js" || ext === ".mjs") await stampJsFile(file);
     else if (ext === ".html") await stampHtmlFile(file);