Bug Fix: Receive remote command responses when in command mode

LeeLeahy2 · LeeLeahy2 · commit 497bf60d9f8d · 2023-03-12T14:21:16.000-10:00
diff --git a/Firmware/LoRaSerial/Radio.ino b/Firmware/LoRaSerial/Radio.ino
@@ -2393,7 +2393,10 @@ PacketType validateDatagram(VIRTUAL_CIRCUIT * vc, PacketType datagramType, uint8
   }
 
   //Verify that there is sufficient space in the serialTransmitBuffer
-  if (inCommandMode || (freeBytes < rxDataBytes))
+  //Apply back pressure if the remote system is trying to send data while
+  //the local system is in command mode.  Remote command responses should
+  //be received.
+  if ((inCommandMode && (datagramType == DATAGRAM_DATA)) || (freeBytes < rxDataBytes))
   {
     if (settings.debugReceive || settings.debugDatagrams)
     {

Original file line number	Diff line number	Diff line change
`@@ -2393,7 +2393,10 @@ PacketType validateDatagram(VIRTUAL_CIRCUIT * vc, PacketType datagramType, uint8`
`2393`	`2393`	`}`
`2394`	`2394`
`2395`	`2395`	`//Verify that there is sufficient space in the serialTransmitBuffer`
`2396`		`- if (inCommandMode \|\| (freeBytes < rxDataBytes))`
	`2396`	`+ //Apply back pressure if the remote system is trying to send data while`
	`2397`	`+ //the local system is in command mode. Remote command responses should`
	`2398`	`+ //be received.`
	`2399`	`+ if ((inCommandMode && (datagramType == DATAGRAM_DATA)) \|\| (freeBytes < rxDataBytes))`
`2397`	`2400`	`{`
`2398`	`2401`	`if (settings.debugReceive \|\| settings.debugDatagrams)`
`2399`	`2402`	`{`