fix: resolve ZipArchive::open() return value not checked, BackupDestination::write() on exceptions, glob() returning false causes type errors

Author: imhayatunnabi

src/BackupDestination/BackupDestination.php

@@ -68,14 +68,16 @@ public function write(string $file): void
 
         $handle = fopen($file, 'r+');
 
-        $this->disk->getDriver()->writeStream(
-            $destination,
-            $handle,
-            $this->getDiskOptions(),
-        );
-
-        if (is_resource($handle)) {
-            fclose($handle);
+        try {
+            $this->disk->getDriver()->writeStream(
+                $destination,
+                $handle,
+                $this->getDiskOptions(),
+            );
+        } finally {
+            if (is_resource($handle)) {
+                fclose($handle);
+            }
         }
     }
 

src/Listeners/EncryptBackupArchive.php

@@ -3,6 +3,7 @@
 namespace Spatie\Backup\Listeners;
 
 use Spatie\Backup\Events\BackupZipWasCreated;
+use Spatie\Backup\Exceptions\BackupFailed;
 use ZipArchive;
 
 class EncryptBackupArchive
@@ -15,7 +16,11 @@ public function handle(BackupZipWasCreated $event): void
 
         $zip = new ZipArchive;
 
-        $zip->open($event->pathToZip);
+        $result = $zip->open($event->pathToZip);
+
+        if ($result !== true) {
+            throw BackupFailed::from(new \Exception("Failed to open zip file for encryption at '{$event->pathToZip}'. ZipArchive error code: {$result}"));
+        }
 
         $this->encrypt($zip);
 

src/Tasks/Backup/BackupJob.php

@@ -289,12 +289,6 @@ protected function dumpDatabases(): array
 
                 $fileName = "{$dbType}-{$dbName}{$timeStamp}.{$this->getExtension($dbDumper)}";
 
-                // @todo is this still relevant or undocumented?
-                if (config('backup.backup.gzip_database_dump')) {
-                    $dbDumper->useCompressor(new GzipCompressor);
-                    $fileName .= '.'.$dbDumper->getCompressorExtension();
-                }
-
                 if ($compressor = $this->config->backup->databaseDumpCompressor) {
                     $dbDumper->useCompressor(new $compressor);
                     $fileName .= '.'.$dbDumper->getCompressorExtension();

src/Tasks/Backup/FileSelection.php

@@ -157,10 +157,14 @@ protected function sanitize(string|array $paths): Collection
     protected function getMatchingPaths(string $path): array
     {
         if ($this->canUseGlobBrace($path)) {
-            return glob(str_replace('*', '{.[!.],}*', $path), GLOB_BRACE);
+            $result = @glob(str_replace('*', '{.[!.],}*', $path), GLOB_BRACE);
+
+            if ($result !== false) {
+                return $result;
+            }
         }
 
-        return glob($path);
+        return glob($path) ?: [];
     }
 
     protected function canUseGlobBrace(string $path): bool

src/Tasks/Backup/Zip.php

@@ -4,6 +4,7 @@
 
 use Illuminate\Support\Str;
 use Spatie\Backup\Config\Config;
+use Spatie\Backup\Exceptions\BackupFailed;
 use Spatie\Backup\Helpers\Format;
 use ZipArchive;
 
@@ -82,7 +83,11 @@ public function humanReadableSize(): string
 
     public function open(): void
     {
-        $this->zipFile->open($this->pathToZip, ZipArchive::CREATE);
+        $result = $this->zipFile->open($this->pathToZip, ZipArchive::CREATE);
+
+        if ($result !== true) {
+            throw BackupFailed::from(new \Exception("Failed to open zip file at '{$this->pathToZip}'. ZipArchive error code: {$result}"));
+        }
     }
 
     public function close(): void