Cannot set batch of agents for collection access

[grantfitzsimmons]

Screen.Recording.2022-11-04.at.12.56.45.PM.mp4

I tried to grant collection access to all collections for a user (ksearcy) in the herb_umass database. This resulted in a prompt asking for me to assign agents for all collections. Once I did, the dialog would not disappear. I then tried to save the record and was unable. Refreshing showed that the changes were not saved.

https://herbumass-testability.test.specifysystems.org/specify/security/user/2/

testability, macOS, chrome

[grantfitzsimmons]

Performing the same set of activities on edge I recieved this warning:

Keep in mind that I created 3 agents using the QCBX during this process.

[maxpatiiuk]

The video you attached does not seem to load.

I wasn't able to replicate the issue in Herb_umass.
My steps:

1. Create a user with collection access in one collection
2. Create agent for it
3. Save - no issues
4. Make user institutional admin
5. Save - dialog about missing agents pops up
6. Set all agents to agents that are already in use
7. Press Save - dialog updates to show that agents are already in use
8. Select agents that are not in use
9. Save - saved without issues

[maxpatiiuk]

For the error on your screenshot, I literally have a comment in code "Not formatting this error nicely, as it shouldn't ever happen".
LOL
(displaying 2 is a bug though - it was supposed to print two spaces, rather than digit 2)

The error means you assigned more than one agent to the same user in the same division - not sure how that happened

[grantfitzsimmons]

Here is the full video walking through how to recreate this bug in edge:

The issue is that if you can create agents with the QCBX, it should be supported. If existing agents are required, it should be enforced.

Screen.Recording.2022-11-18.at.4.14.48.PM.mp4

[maxpatiiuk]

I was able to reproduce the bug from your last video in edge, but not in testability. Since it doesn't happen in next release, I won't investigate it further

I was able to reproduce the behavior you mentioned in the initial comment on testability.

It happens because sp7 does not set Agent.division when creating a new agent, and so when you choose an agent in the Set User Agents dialog, back-end does not detect that you set an agent in that division, because agent is not connected to the division.

@grantfitzsimmons do you know of sp6 sets that relationship, and if there could be any problem with force-setting that field in sp7?

From the code, it looks like sp7 used to enforce that relationship, but it was disabled in 2013: e19e5fa

[grantfitzsimmons]

Specify 6 sets that relationship automatically. All agents are scoped to the division so it is necessary to have that set when an agent is created.

It should be enforced. I can't imagine there would be a problem unless Specify 7 has allowed users to reference agents in other divisions... which would break the model!