Going to a record set triggers a form change

[realVinayak]

Describe the bug
If you click on 'Record Sets', then I am shown the list of record sets for that user. Try going from one record set to another and I get the dialog message 'This form has not been saved' even if I didn't change anything. A major issue because I wanted to know if I accidentally changed anything or not. This is in production by the way.

To Reproduce
Steps to reproduce the behavior:

1. Click on 'Record Sets' on the menu
2. Click on any record set
3. Click on 'Record Sets' again and go to another record set
4. The dialog 'This form has not been saved.' shows up.

Expected behavior
Shouldn't trigger the form change. Or at least tell me what changed.

[realVinayak]

The url in the screenshot: https://osuorton3823-edge.test.specifysystems.org/

[realVinayak]

Happens in Chrome, Edge and Firefox

[maxpatiiuk]

You have an unsaved form behind the dialog.
Opening the dialog is fine and doesn't trigger the unload protect dialog.
Actually clicking on a record set would replace the form with a record set, thus unload protect dialog is triggered to warn you about this.
Not a bug.
Though, if you think this is a UX issue, do you have suggestions on improving this?

[realVinayak]

Not showing the save dialog if there actually weren't changes! I discovered this while on production database and thought I changed the form

…

On Tue, Mar 28, 2023, 20:26 Max Patiiuk ***@***.***> wrote: Closed #3259 <#3259> as not planned. — Reply to this email directly, view it on GitHub <#3259 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOSKLYXO3CKSZJUBRL5JBP3W6OFVVANCNFSM6AAAAAAWKRRVMU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[maxpatiiuk]

Not showing the save dialog if there actually weren't changes

Ah, that's a separate issue, not connected to record sets.

Two bugs here:

1. When collection object is created, collection relationship is set, which triggers save blocker
2. catalogedDatePrecision is set to 1 by default, which triggers save blocker

[maxpatiiuk]

TODO:

1. Check if the two bugs mentioned in the previous commend (Going to a record set triggers a form change #3259 (comment)) are still reproducible on xml-editor
2. Fix them