Feature/fix url default value (#17)

* Set default URL value to be the ClickUp API v2 URL. Fixes #13

* Fix typos

* Guard against Laravel setting configs as empty strings

Author: ssfinney

src/Api/Client.php

@@ -219,7 +219,10 @@ public function request($path, $data = [], $method = 'GET'): ?array
      */
     public function setConfigs(array $configs): self
     {
-        $this->configs = $configs;
+        // Replace empty strings with nulls in config values
+        $this->configs = array_map(function($value) {
+            return $value === "" ? null : $value;
+        }, $configs);
 
         return $this;
     }
@@ -241,8 +244,9 @@ public function setToken($token): self
     /**
      * URL to ClickUp
      *
-     * If path is passed in, then append it to the end.  By default, it will use the url
+     * If path is passed in, then append it to the end. By default, it will use the url
      * in the configs, but if an url is passed in as second parameter, then it is used.
+     * If no url is found, it will use the hard-coded v2 ClickUp API URL.
      *
      * @param string|null $path
      * @param string|null $url
@@ -251,6 +255,8 @@ public function setToken($token): self
      */
     public function uri($path = null, $url = null): string
     {
-        return rtrim(($url ?: $this->configs['url']), '/') . (Str::startsWith($path, '?') ? null : '/') . ltrim($path, '/');
+        $url = $url ?? $this->configs['url'] ?? 'https://api.clickup.com/api/v2';
+
+        return rtrim($url, '/') . (Str::startsWith($path, '?') ? null : '/') . ltrim($path, '/');
     }
 }

tests/Api/ClientTest.php

@@ -81,7 +81,7 @@ public function it_can_be_constructed()
     /**
      * @test
      */
-    public function it_expects_the_first_argument_tobe_an_array()
+    public function it_expects_the_first_argument_to_be_an_array()
     {
         $this->expectException(TypeError::class);
 
@@ -91,7 +91,7 @@ public function it_expects_the_first_argument_tobe_an_array()
     /**
      * @test
      */
-    public function it_expects_the_second_argument_tobe_a_guzzle()
+    public function it_expects_the_second_argument_to_be_a_guzzle()
     {
         $this->expectException(TypeError::class);
 
@@ -150,6 +150,34 @@ public function it_allows_setting_the_configs()
         $this->assertInstanceOf(Client::class, $return);
     }
 
+    /**
+     * @test
+     */
+    public function it_sets_url_to_default_value_if_not_passed_in()
+    {
+        $this->client->setConfigs(
+            [
+                'url' => null,
+            ]
+        );
+
+        $this->assertEquals('https://api.clickup.com/api/v2/', $this->client->uri());
+    }
+
+    /**
+     * @test
+     */
+    public function it_sets_url_to_default_value_if_its_an_empty_string()
+    {
+        $this->client->setConfigs(
+            [
+                'url' => "",
+            ]
+        );
+
+        $this->assertEquals('https://api.clickup.com/api/v2/', $this->client->uri());
+    }
+
     /**
      * @test
      */
@@ -201,8 +229,8 @@ public function it_builds_correct_uri()
         $this->assertEquals('http://some/place/resource', $this->client->uri('/resource'), 'no double slash');
         $this->assertEquals('http://some/place/resource/', $this->client->uri('resource/'), 'leaves end slash');
         $this->assertEquals(
-            'http://some/place?paramater=value',
-            $this->client->uri('?paramater=value'),
+            'http://some/place?parameter=value',
+            $this->client->uri('?parameter=value'),
             'query string'
         );
         $this->assertEquals(