Skip to content

Commit 177a7d3

Browse files
committed
change export url parameters
pdftitle => book_title pdfns_title => book_title pdfns_ns => book_ns pdfns_order => book_order pdfns_depth => book_nsdepth pdfbook_title => book_title Temporary an fallback is left for: pdftitle and pdfbook_title NOT for the pdfns_* parameters
1 parent c2e5bcf commit 177a7d3

File tree

3 files changed

+15
-10
lines changed

3 files changed

+15
-10
lines changed

_test/syntax_exportlink.test.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function test_parser () {
2323
array(
2424
'dw2pdf_exportlink',
2525
array(
26-
'link' => '?do=export_pdfns&pdfns_ns=foo:bar&pdfns_title=Foo',
26+
'link' => '?do=export_pdfns&book_ns=foo:bar&book_title=Foo',
2727
'title' => 'Export namespace "foo:bar:" to file Foo.pdf',
2828
5,
2929
1,
@@ -35,7 +35,7 @@ function test_parser () {
3535
);
3636
$this->assertEquals($expected_parser_response,$parser_response[2]);
3737
$renderer_response = p_render('xhtml',$parser_response,$info);
38-
$expected_renderer_response = 'doku.php?id=foo:bar:start&amp;do=export_pdfns&amp;pdfns_ns=foo:bar&amp;pdfns_title=Foo" class="wikilink2" title="foo:bar:start" rel="nofollow">Export namespace &quot;foo:bar:&quot; to file Foo.pdf</a>';
38+
$expected_renderer_response = 'doku.php?id=foo:bar:start&amp;do=export_pdfns&amp;book_ns=foo:bar&amp;book_title=Foo" class="wikilink2" title="foo:bar:start" rel="nofollow">Export namespace &quot;foo:bar:&quot; to file Foo.pdf</a>';
3939
$trimmed_renderer_response = substr($renderer_response,strpos($renderer_response,'doku.php'),-5);
4040
$trimmed_renderer_response = trim($trimmed_renderer_response);
4141
$this->assertEquals($expected_renderer_response,$trimmed_renderer_response);

action.php

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ public function __construct() {
3535

3636
/**
3737
* Register the events
38+
*
39+
* @param Doku_Event_Handler $controller
3840
*/
3941
public function register(Doku_Event_Handler $controller) {
4042
$controller->register_hook('ACTION_ACT_PREPROCESS', 'BEFORE', $this, 'convert', array());
@@ -142,32 +144,33 @@ protected function collectExportPages(Doku_Event $event) {
142144

143145
if($ACT == 'export_pdf') {
144146
$list[0] = $ID;
145-
$title = $INPUT->str('pdftitle');
146-
if(!$title) {
147+
$title = $INPUT->str('pdftitle'); //DEPRECATED
148+
$title = $INPUT->str('book_title', $title, true);
149+
if(empty($title)) {
147150
$title = p_get_first_heading($ID);
148151
}
149152

150153
} elseif($ACT == 'export_pdfns') {
151154
//check input for title and ns
152-
if(!$title = $INPUT->str('pdfns_title')) {
155+
if(!$title = $INPUT->str('book_title')) {
153156
$this->showPageWithErrorMsg($event, 'needtitle');
154157
return false;
155158
}
156-
$pdfnamespace = cleanID($INPUT->str('pdfns_ns'));
159+
$pdfnamespace = cleanID($INPUT->str('book_ns'));
157160
if(!@is_dir(dirname(wikiFN($pdfnamespace . ':dummy')))) {
158161
$this->showPageWithErrorMsg($event, 'needns');
159162
return false;
160163
}
161164

162165
//sort order
163-
$order = $INPUT->str('pdfns_order', 'natural', true);
166+
$order = $INPUT->str('book_order', 'natural', true);
164167
$sortoptions = array('pagename', 'date', 'natural');
165168
if(!in_array($order, $sortoptions)) {
166169
$order = 'natural';
167170
}
168171

169172
//search depth
170-
$depth = $INPUT->int('pdfns_depth', 0);
173+
$depth = $INPUT->int('book_nsdepth', 0);
171174
if($depth < 0) {
172175
$depth = 0;
173176
}
@@ -193,7 +196,9 @@ protected function collectExportPages(Doku_Event $event) {
193196

194197
} elseif(isset($_COOKIE['list-pagelist']) && !empty($_COOKIE['list-pagelist'])) {
195198
//is in Bookmanager of bookcreator plugin a title given?
196-
if(!$title = $INPUT->str('pdfbook_title')) {
199+
$title = $INPUT->str('pdfbook_title'); //DEPRECATED
200+
$title = $INPUT->str('book_title', $title, true);
201+
if(empty($title)) {
197202
$this->showPageWithErrorMsg($event, 'needtitle');
198203
return false;
199204
} else {

syntax/exportlink.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public function handle($match, $state, $pos, Doku_Handler $handler) {
5858
resolve_pageid(getNS($ID),$id,$exists);
5959
$ns = getNS($id);
6060
$title = substr($match,strpos($match,'|')+1,-2);
61-
$link = '?do=export_pdfns&pdfns_ns=' . $ns . '&pdfns_title=' . $title;
61+
$link = '?do=export_pdfns&book_ns=' . $ns . '&book_title=' . $title;
6262
return array('link' => $link, 'title' => sprintf($this->getLang('export_ns'),$ns,$title),$state, $pos);
6363
}
6464

0 commit comments

Comments
 (0)