Skip to content

Commit f2a3a2a

Browse files
authored
Merge pull request JanKaul#252 from JanKaul/extend-fake-object-store-url
allow space in object-store-url
2 parents 7f0b936 + 3c818d6 commit f2a3a2a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

catalogs/iceberg-file-catalog/src/lib.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,10 @@ pub mod tests {
896896
.await
897897
.unwrap();
898898

899-
assert_eq!(std::str::from_utf8(&version_hint).unwrap(), "1");
899+
assert_eq!(
900+
std::str::from_utf8(&version_hint).unwrap(),
901+
"s3://warehouse/tpch/lineitem/metadata/v1.metadata.json"
902+
);
900903

901904
let files = object_store.list(None).collect::<Vec<_>>().await;
902905

datafusion_iceberg/src/table.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -344,6 +344,7 @@ fn fake_object_store_url(table_location_url: &str) -> ObjectStoreUrl {
344344
.replace('-', "-2D")
345345
.replace('/', "-2F")
346346
.replace(':', "-3A")
347+
.replace(' ', "-20")
347348
))
348349
.expect("Invalid object store url.")
349350
}

0 commit comments

Comments
 (0)