Skip to content

Commit 092207b

Browse files
committed
polish
1 parent 0815b1a commit 092207b

File tree

2 files changed

+8
-9
lines changed

2 files changed

+8
-9
lines changed

client/src/main/java/io/split/client/SplitClientConfig.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
import java.util.HashSet;
1919
import java.util.LinkedHashSet;
2020
import java.util.List;
21+
import java.util.Map;
2122
import java.util.Properties;
2223
import java.util.concurrent.ThreadFactory;
2324
import java.io.InputStream;
@@ -1183,15 +1184,19 @@ private void verifyFallbackTreatments() {
11831184
if (_fallbackTreatments == null)
11841185
return;
11851186

1187+
FallbackTreatment processedGlobalFallbackTreatment = _fallbackTreatments.getGlobalFallbackTreatment();
1188+
Map<String, FallbackTreatment> processedByFlagFallbackTreatment = _fallbackTreatments.getByFlagFallbackTreatment();
1189+
11861190
if (_fallbackTreatments.getGlobalFallbackTreatment() != null) {
1187-
_fallbackTreatments.setGlobalFallbackTreatment(new FallbackTreatment(
1191+
processedGlobalFallbackTreatment = new FallbackTreatment(
11881192
isValidTreatment(_fallbackTreatments.getGlobalFallbackTreatment().getTreatment(), "Fallback treatments"),
1189-
_fallbackTreatments.getGlobalFallbackTreatment().getConfig()));
1193+
_fallbackTreatments.getGlobalFallbackTreatment().getConfig());
11901194
}
11911195

11921196
if (_fallbackTreatments.getByFlagFallbackTreatment() != null) {
1193-
_fallbackTreatments.setByFlagFallbackTreatment(isValidByFlagTreatment(_fallbackTreatments.getByFlagFallbackTreatment(), "config"));
1197+
processedByFlagFallbackTreatment = isValidByFlagTreatment(_fallbackTreatments.getByFlagFallbackTreatment(), "config");
11941198
}
1199+
_fallbackTreatments = new FallbackTreatmentsConfiguration(processedGlobalFallbackTreatment, processedByFlagFallbackTreatment);
11951200
}
11961201

11971202
public SplitClientConfig build() {

client/src/main/java/io/split/client/dtos/FallbackTreatmentsConfiguration.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,6 @@ public FallbackTreatmentsConfiguration(FallbackTreatment globalFallbackTreatment
1414
public FallbackTreatment getGlobalFallbackTreatment() {
1515
return _globalFallbackTreatment;
1616
}
17-
public void setGlobalFallbackTreatment(FallbackTreatment newValue) {
18-
_globalFallbackTreatment = newValue;
19-
}
2017

2118
public Map<String, FallbackTreatment> getByFlagFallbackTreatment() { return _byFlagFallbackTreatment;}
22-
public void setByFlagFallbackTreatment(Map<String, FallbackTreatment> newValue) {
23-
_byFlagFallbackTreatment = newValue;
24-
}
2519
}

0 commit comments

Comments
 (0)