polish tests

Author: chillaq

client/src/main/java/io/split/inputValidation/ImpressionPropertiesValidator.java

@@ -3,9 +3,10 @@
 import java.util.Map;
 
 public class ImpressionPropertiesValidator {
-    private ImpressionPropertiesValidator() {
+    ImpressionPropertiesValidator() {
         throw new IllegalStateException("Utility class");
     }
+
     public static ImpressionPropertiesValidatorResult propertiesAreValid(Map<String, Object> properties) {
         EventsValidator.EventValidatorResult result = EventsValidator.propertiesAreValid(properties);
         return new ImpressionPropertiesValidatorResult(result.getSuccess(), result.getEventSize(), result.getValue());

client/src/test/java/io/split/client/SplitFactoryImplTest.java

@@ -172,8 +172,6 @@ public void testFactoryConsumerInstantiation() throws Exception {
         Mockito.verify(telemetrySynchronizer, Mockito.times(1)).synchronizeConfig(Mockito.anyObject(), Mockito.anyLong(), Mockito.anyObject(), Mockito.anyObject());
     }
 
-    // TODO Enable test after pluggable classes update
-    @Ignore
     @Test
     public void testFactoryConsumerInstantiationRetryReadiness() throws Exception {
         CustomStorageWrapper customStorageWrapper = Mockito.mock(CustomStorageWrapper.class);

client/src/test/java/io/split/inputValidation/ImpressionPropertiesValidatorTest.java

@@ -10,6 +10,12 @@
 import java.util.Map;
 
 public class ImpressionPropertiesValidatorTest {
+
+    @Test(expected = IllegalStateException.class)
+    public void testConstructorException() {
+        ImpressionPropertiesValidator iv = new ImpressionPropertiesValidator();
+    }
+
     @Test
     public void propertiesAreValidWorks() {
         Map<String, Object> properties = new HashMap<String, Object>()

testing/src/test/java/io/split/client/testing/SplitScenarioAnnotationTest.java

@@ -1,5 +1,7 @@
 package io.split.client.testing;
 
+import io.split.client.api.Key;
+import io.split.client.dtos.EvaluationOptions;
 import io.split.client.testing.annotations.SplitScenario;
 import io.split.client.testing.annotations.SplitSuite;
 import io.split.client.testing.annotations.SplitTest;
@@ -10,6 +12,9 @@
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.HashMap;
 import java.util.Objects;
 
 /**
@@ -58,8 +63,57 @@ public void testDefaultScenario() {
         Assert.assertEquals(3, splitClient.tests().size());
         Assert.assertEquals(ON_TREATMENT, splitClient.getTreatment(ARBITRARY_KEY, DEFAULT_PARENT_FEATURE));
         Assert.assertEquals(ON_TREATMENT, splitClient.getTreatment(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatment(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new HashMap<>()));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatment(new Key(ARBITRARY_KEY, ARBITRARY_KEY), DEFAULT_CLIENT_FEATURE, new HashMap<>()));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentWithConfig(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new HashMap<>()).treatment());
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentWithConfig(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE).treatment());
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentWithConfig(new Key(ARBITRARY_KEY, ARBITRARY_KEY), DEFAULT_CLIENT_FEATURE, new HashMap<>()).treatment());
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatments(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE)).get(DEFAULT_CLIENT_FEATURE));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatments(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>()).get(DEFAULT_CLIENT_FEATURE));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatments(new Key(ARBITRARY_KEY, ARBITRARY_KEY), Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>()).get(DEFAULT_CLIENT_FEATURE));
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentsWithConfig(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE)).get(DEFAULT_CLIENT_FEATURE).treatment());
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentsWithConfig(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>()).get(DEFAULT_CLIENT_FEATURE).treatment());
+        Assert.assertEquals(ON_TREATMENT, splitClient.getTreatmentsWithConfig(new Key(ARBITRARY_KEY, ARBITRARY_KEY), Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>()).get(DEFAULT_CLIENT_FEATURE).treatment());
         Assert.assertEquals(OFF_TREATMENT, splitClient.getTreatment(ARBITRARY_KEY, OVERRIDDEN_PARENT_FEATURE));
         Assert.assertEquals(CONTROL_TREATMENT, splitClient.getTreatment(ARBITRARY_KEY, CONTROL_FEATURE));
+
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset",  new HashMap<>()));
+        Assert.assertEquals(null, splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset"));
+        Assert.assertEquals(null, splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset"));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"),  new HashMap<>()));
+        Assert.assertEquals(null, splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset")));
+        Assert.assertEquals(null, splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset")));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset",  new HashMap<>()));
+        Assert.assertEquals(null, splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset"));
+        Assert.assertEquals(null, splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset"));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"),  new HashMap<>()));
+        Assert.assertEquals(null, splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset")));
+        Assert.assertEquals(null, splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset")));
+
+        Assert.assertEquals(null, splitClient.getTreatment(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatment(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatment(new Key(ARBITRARY_KEY, ARBITRARY_KEY), DEFAULT_CLIENT_FEATURE, new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatmentWithConfig(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatmentWithConfig(ARBITRARY_KEY, DEFAULT_CLIENT_FEATURE, new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatmentWithConfig(new Key(ARBITRARY_KEY, ARBITRARY_KEY), DEFAULT_CLIENT_FEATURE, new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatments(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatments(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfig(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(null, splitClient.getTreatmentsWithConfig(ARBITRARY_KEY, Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>(), new EvaluationOptions(new HashMap<>())).get(DEFAULT_CLIENT_FEATURE));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfig(new Key(ARBITRARY_KEY, ARBITRARY_KEY), Arrays.asList(DEFAULT_CLIENT_FEATURE),  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset",  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset", new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSet(ARBITRARY_KEY, "flagset", new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"),  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset",  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset", new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSet(ARBITRARY_KEY, "flagset", new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"),  new HashMap<>(), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"), new EvaluationOptions(new HashMap<>())));
+        Assert.assertEquals(new HashMap<>(), splitClient.getTreatmentsWithConfigByFlagSets(ARBITRARY_KEY, Arrays.asList("flagset"), new EvaluationOptions(new HashMap<>())));
     }
 
     /**